search

ethereum-optimism / optimistic-specs

Optimistic: Bedrock, is a protocol that strives to be an extremely simple optimistic rollup that maintains 1:1 compatibility with Ethereum
MIT License
167 stars 35 forks source link

contracts: L2xDomainMessenger API compat #442

Closed tynes closed 2 years ago

tynes commented 2 years ago

Description

Ensure to have the l1CrossDomainMessenger getter on the L2CrossDomainMessenger to guarantee backwards compatibility with existing contracts that may be integrated with the L2CrossDomainMessenger.

codecov-commenter commented 2 years ago

Codecov Report

Merging #442 (f0439db) into main (92fccc2) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
- Coverage   51.50%   51.49%   -0.02%     
==========================================
  Files          70       70              
  Lines        7582     7582              
==========================================
- Hits         3905     3904       -1     
- Misses       3154     3155       +1     
  Partials      523      523
Impacted Files Coverage Δ
opnode/rollup/driver/state.go 72.66% <0.00%> (-0.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92fccc2...f0439db. Read the comment docs.

tynes commented 2 years ago

Closing this in favor of https://github.com/ethereum-optimism/optimism/pull/2567