search

ethereum-optimism / stack-docs

OP Stack documentation
13 stars 32 forks source link

updated "docsRepo" variable to the updated repository #7

Closed JacobHomanics closed 1 year ago

JacobHomanics commented 1 year ago

Description

When on any given page, pressing the "Edit this page" button would take you to a Github 404 page. Presumably where the docs used to live. The update to the config is the base URL for the new docs repo.

netlify[bot] commented 1 year ago

Deploy request for opstack-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 1af09ea4d0aaff37a72334905d2a62494bfbffef
bryanchriswhite commented 1 year ago

@Hotmanics did you intentionally reformat the entire file (e.g. replace double- with single-quotes, etc.)?

Personally, I find the original format more readable (and consistent), especially with respect to the whitespace. This diff seems excessive to me just to effect what would otherwise be a one-line change (see: #9).

JacobHomanics commented 1 year ago

@Hotmanics did you intentionally reformat the entire file (e.g. replace double- with single-quotes, etc.)?

Personally, I find the original format more readable (and consistent), especially with respect to the whitespace. This diff seems excessive to me just to effect what would otherwise be a one-line change (see: #9).

I did not. Must've been my auto-formatter.

Made a new commit with the proposed changes and no autoformatting - keeping the original formatting in place. Check it out here: https://github.com/ethereum-optimism/stack-docs/pull/12.

Going to close this PR