ethereum / ethereum-org-website

Ethereum.org is a primary online resource for the Ethereum community.
https://ethereum.org/
MIT License
5.04k stars 4.78k forks source link

New design for Staking cards #13115

Open nloureiro opened 3 months ago

nloureiro commented 3 months ago

Is your feature request related to a problem? Please describe.

On exploring a new color scheme for the Design system, @ddannehh ended up designing a better version of the Stake cards.

We should isolate this design and implement it under the current design system.

this is the base proposal that should be worked to be implemented under the existing design system Screen Shot 2024-06-07 09 21 39 AM

Link to the figma file https://www.figma.com/design/wdBEEuqbT2t94jp92DTITy/New-Staking-cards?node-id=1-3&t=fJe1FAqkufXGCf9H-1

ddannehh commented 3 months ago

Translated to current DS: https://www.figma.com/design/wdBEEuqbT2t94jp92DTITy/New-Staking-cards?node-id=1-416&t=vnKr7pv1chG3XhNX-1

Staking Cards
ddannehh commented 3 months ago

PS: Content issue, BloxStaking has been shutdown :)

nloureiro commented 3 months ago

PS: Content issue, BloxStaking has been shutdown :)

can you open a new issue with this? it's easier to have a contributor to remove it Thank you

nloureiro commented 3 months ago

@wackerow, long story short, we have new cards for staking :)

what do you think?

wackerow commented 3 months ago

Agreed. I think this looks nice, though it's obviously a minimal change from the existing design... same layout, same structure and same information. We have a bit more data collected in the data JSON that we're not really displaying, ie socials, or fees... we could also consider ways to include these values.

wackerow commented 3 months ago

I like the switch to colored logos... the monochromatic look was challenging to maintain and arguably not worth it.

nloureiro commented 3 months ago

Agreed. I think this looks nice, though it's obviously a minimal change from the existing design... same layout, same structure and same information. We have a bit more data collected in the data JSON that we're not really displaying, ie socials, or fees... we could also consider ways to include these values.

on nice!!!

can you add that extra data on Figma?

ddannehh commented 3 months ago

Included fees in the sub-header text and added social icons at the bottom.

Saas Providers

Probably worth noting as well, the Key generators below the Saas Providers have a slightly different layout since they don't require a minimum ETH stake and have no fees

Key Generators
wackerow commented 3 months ago

Yeah this looks great... like the simple addition with the socials and the fees

wackerow commented 3 months ago

If I'm correct looks like it may pull away from DS a bit? @nloureiro checking in if this change was something you were interested in planning for or not.

nloureiro commented 3 months ago

If I'm correct looks like it may pull away from DS a bit? @nloureiro checking in if this change was something you were interested in planning for or not.

Actually, @ddannehh made all the adjustments to make it a DS component.

From my side, it's ready to be coded unless you see some adjustments needed.

He also made a variation on the tabs that I like; it might be a different issue, but it goes a long with these cards really well. Screen Shot 2024-06-20 09 37 31 AM

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity.

konopkja commented 1 month ago

These cards look good to me, is there any blocker for implementation? Can we give this to the contributor community?

Included fees in the sub-header text and added social icons at the bottom.

Saas Providers

Probably worth noting as well, the Key generators below the Saas Providers have a slightly different layout since they don't require a minimum ETH stake and have no fees

Key Generators
github-actions[bot] commented 1 week ago

This issue is stale because it has been open 30 days with no activity.

nloureiro commented 5 days ago

The design is finished; does anyone want to implement this?

It's mostly a style change, it is good first issue for any dev out there