search

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony
GNU Lesser General Public License v3.0
2.18k stars 1.1k forks source link

"throw new RuntimeException("Not supported")" in many funs of RepositoryImpl.java #1226

Closed w1397800 closed 5 years ago

w1397800 commented 5 years ago

There are lots of funs which contains "throw new RuntimeException("Not supported")" in "org.ethereum.db.RepositoryImpl.java".
eg: public Set getStorageKeys(byte[] addr) { throw new RuntimeException("Not supported"); } Is there any implemented function replacing it?

mkalinin commented 5 years ago

It's hardly feasible to support some methods in main repository implementation. But they are pretty useful in tests, take a look at this implementation https://github.com/ethereum/ethereumj/blob/561582b965648f8d359b50d4c40c0984e5a4d48e/ethereumj-core/src/test/java/org/ethereum/jsontestsuite/suite/IterableTestRepository.java#L266-L269

w1397800 commented 5 years ago

thanks for your reply.