Dependency on the Chain class which is slated to be deprecated.
Registrar and Provider API should be independent.
Provider access to registrar should be done via provider backend API.
How it should be fixed.
Step 1
Minimal code change to remove chain as dependency and switch to constructor taking web3, registrar and provider_backends.
Step 2
Refactor provider API to use minimal ERC190 package spec to store serialized packages.
Introduce new API for setting package name in all places where storing deployments would happen.
if a package name is not provided, create one using automated whole number versioning name generation. ContractName-v1.
if package name is not provided raise PendingDeprecation warning indicating that it will be required soon
store all deployments in a JSON document for the time being.
figure out strategy for test runs to ensure we don't pollute the registrar JSON file.
Step 3
Decouple provider and registrar into independent backend APIs.
Registrar.record_package
Registrar.lookup_package
Provider.get_contract_address
Provider.is_contract_available
Provider.is_contract_available
Provider.are_contract_dependencies_available
Provider.get_contract_instance (replaces and deprecates Provider.get_contract)
Provider.get_contract_factory
Provider.get_base_contract_factory
Deprecate: Provider.get_all_contract_data
Deprecate: Provider.get_all_contract_names
Deprecate: Provider.get_contract_data
The term contract_identifier in these apis should use scheme similar to the one laid out in https://github.com/ethereum/populus/issues/373 for differentiating between which contract is being retrieved.
What was wrong?
Primary things that are being fixed here.
Chainclass which is slated to be deprecated.How it should be fixed.
Step 1
Minimal code change to remove
chainas dependency and switch to constructor takingweb3,registrarandprovider_backends.Step 2
Refactor provider API to use minimal ERC190 package spec to store serialized packages.
ContractName-v1.PendingDeprecationwarning indicating that it will be required soonStep 3
Decouple provider and registrar into independent backend APIs.
Registrar.record_packageRegistrar.lookup_packageProvider.get_contract_addressProvider.is_contract_availableProvider.is_contract_availableProvider.are_contract_dependencies_availableProvider.get_contract_instance(replaces and deprecatesProvider.get_contract)Provider.get_contract_factoryProvider.get_base_contract_factoryProvider.get_all_contract_dataProvider.get_all_contract_namesProvider.get_contract_dataThe term
contract_identifierin these apis should use scheme similar to the one laid out in https://github.com/ethereum/populus/issues/373 for differentiating between which contract is being retrieved.