Closed prathmeshranaut closed 1 year ago
The CI failures are affecting a bunch of our libraries, not your fault. We're looking into it.
Hey @prathmeshranaut ! Thanks for all the help. I like how you've broken these up. To keep it consistent with our other libraries, I'd ask that you take a look at the template. We have our isort
config in the tox.ini
rather than a separate config file.
Otherwise, I'd like to get a separate PR in to make the CI changes, then you can rebase on that. Just so different concerns are mushed together here. I can take care of that first thing tomorrow if you don't get to it.
@pacrob Moved the isort
config to tox.ini
. And rebased the CI changes with master
.
Looks good, @prathmeshranaut , thanks!
What was wrong?
Imports are not sorted.
Related to Issue https://github.com/ethereum/py-evm/issues/2094
How was it fixed?
Added
isort
, a tool to sort imports, in the linting process.Adding lint setup + linting files would be a large PR to review. I've decided to split it up into two parts.
In this PR, I've added
isort
and related commands tosetup.py
,Makefile
andtox
. In the follow up PR, I will be runningmake lint-roll
. It will be easier for repo maintainers to checksum the changes and review the lint changes.Let me know if I missed anything in the contribution process.
Todo:
[x] Clean up commit history
[x] Add or update documentation related to these changes
[x] Add entry to the release notes
Cute Animal Picture