search

ethereum / remix-project

Remix is a browser-based compiler and IDE that enables users to build Ethereum contracts with Solidity language and to debug transactions.
https://remix-ide.readthedocs.io
MIT License
2.48k stars 966 forks source link

Fix crash on right-click after closing tab #5415

Closed dominikrudzki closed 2 days ago

dominikrudzki commented 6 days ago

5414 The application crashes because when a file is opened, focus is set on it. After closing the file, the browserReducer sets the focusElement in the state to an empty array. When you right-click in the file explorer, a condition tries to read the key of the first element in the focusElement array, which is empty, causing the crash.

netlify[bot] commented 6 days ago

Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
Latest commit 98d146722e8c9cde07b37076edddcef231dcadab
ryestew commented 2 days ago

Thanks so much for your timely contribution. Unfortunately, one of the Remix team members made a PR just before you did and that one got merged. https://github.com/ethereum/remix-project/pull/5417/

We really appreciated your contribution and the explanation of your update. Thanks so much! I do hope you can contribute again.