etherlabsio / ai-engine

Core AI services and functions powering the ETHER Platform
MIT License
0 stars 0 forks source link

Graph & Keyphrase changes for uniform operations across services #170

Closed shashankpr closed 4 years ago

shashankpr commented 4 years ago

Context

With the introduction of graph service, it became important that other services that send requests to graph service (like, keyphrase, recommended watchers) modify the struct of their data such that it can be consumed by the graph service. Without proper class structs and schema, a small inclusion or deletion causes lot of changes across services.

Hence, this PR primarily addresses having a well-defined class definitions which can be used uniformly across services.

Advantages

  1. Defined class types and schema allows for easier understanding and implementation.
  2. Uniform marshalling and unmarshalling without having to tinker too much for every small change that is required in other dependant service.
  3. Automatically generate schemas instead of maintaining it manually.
  4. Easier test-cases

Changes

This PR deals with part of the tasks listed in #172 and #163