search

ethjs / ethjs-contract

A simple contract object for the Ethereum RPC layer.
MIT License
20 stars 28 forks source link

Make ContractFactory.new return a promise #19

Closed adipascu closed 6 years ago

adipascu commented 6 years ago

This is a fix for #17

I just noticed that #18 is already in the works, I posted this as a smaller alternative (feel free to close/not merge).

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling bf3939848765ba606d4537a3ddf0c3fb2a0ab1a3 on adipascu:master into 7a75bfce6c0c9bbd17e437d8f6c825f7c96df241 on ethjs:master.

adipascu commented 6 years ago

PS: The unit test that checks for this specific bug has passed (false positive) because it runs against an older version of ethjs-query. This PR does not fix the unit test.

SilentCicero commented 6 years ago

@adipascu should be fixed as of version 1.9, can you try again?

adipascu commented 6 years ago

@SilentCicero Will test in a week (I'm working a different project right now).

SilentCicero commented 6 years ago

@adipascu thanks so much, this has been addressed in 2.0. Thank you for the commit though.