Refactor+improvements - Githubissues

ethjs / ethjs-contract

A simple contract object for the Ethereum RPC layer.

MIT License

20 stars 28 forks source link

Refactor+improvements #20

Closed kumavis closed 6 years ago

kumavis commented 6 years ago

rewrite tests to use async/await
refactor index based on @danfinlay's work
move tests to ganache-core

Fixes #4

kumavis commented 6 years ago

weird travis seems to have ignored my node_js flag?

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling d35e0e9244da68bbe369c9597bbdfbb40ebb9b97 on kumavis:refactor+improvements into 4efdbc20089d8d50ffe3f392b7cc30ebe836010c on ethjs:master.

kumavis commented 6 years ago

weird, seems like it got my node_js flag the second time

SilentCicero commented 6 years ago

Will review again and most likely push early next week @kumavis