search

ethz-adrl / towr

A light-weight, Eigen-based C++ library for trajectory optimization for legged robots.
http://wiki.ros.org/towr
BSD 3-Clause "New" or "Revised" License
933 stars 234 forks source link

Small extension to CMakelist of "towr_ros" package #31

Closed JaFeKl closed 6 years ago

JaFeKl commented 6 years ago

Hello guys,

I am currently implementing my robot model to work with your package. I just have a minor suggestion: When people like me try to use header files from the towr_ros package it would be convenient if you install the header files of it by changing the CMakeList of the "towr_ros" package:

include_directories(
  include
  ${catkin_INCLUDE_DIRS}
)
# Mark header files for installation
install(
  DIRECTORY include/${PROJECT_NAME}/
  DESTINATION ${CATKIN_PACKAGE_INCLUDE_DESTINATION}
  FILES_MATCHING PATTERN "*.h"
)

Then people, who download your software and try stuff out don't have to face issues when compiling because of header files, which weren't found :)

awinkler commented 6 years ago

Thanks, that makes sense and will be implemented. You can also just open a pull-request if you want.