ethz-asl / wavemap

Fast, efficient and accurate multi-resolution, multi-sensor 3D occupancy mapping
https://ethz-asl.github.io/wavemap/
BSD 3-Clause "New" or "Revised" License
434 stars 38 forks source link

Compile error due to tracy #33

Closed astumpf closed 1 year ago

astumpf commented 1 year ago

Describe the bug Seems that the tracy_catkin package does not install headers and libs into a install space as required.

To Reproduce Steps to reproduce the behavior:

  1. Setup catkin workspace in install mode (catkin config --install); may be also reproducable with an extending workspace
  2. Install wavemap as described in the tutorial
  3. Run catkin build wavemap_all

Expected behavior No build errors

Observed outcome Tracy headers are not available.

Screenshots

Errors     << wavemap:make /home/alex/er/logs/wavemap/build.make.229.log
/home/alex/er/src/wavemap/libraries/wavemap/src/data_structure/volumetric/hashed_chunked_wavelet_octree.cc:5:10: fatal error: tracy/Tracy.hpp: No such file or directory
    5 | #include <tracy/Tracy.hpp>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/wavemap.dir/src/data_structure/volumetric/hashed_chunked_wavelet_octree.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/home/alex/er/src/wavemap/libraries/wavemap/src/data_structure/volumetric/hashed_chunked_wavelet_octree_block.cc:3:10: fatal error: tracy/Tracy.hpp: No such file or directory
    3 | #include <tracy/Tracy.hpp>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/wavemap.dir/src/data_structure/volumetric/hashed_chunked_wavelet_octree_block.cc.o] Error 1
/home/alex/er/src/wavemap/libraries/wavemap/src/data_structure/volumetric/hashed_wavelet_octree.cc:5:10: fatal error: tracy/Tracy.hpp: No such file or directory
    5 | #include <tracy/Tracy.hpp>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/wavemap.dir/src/data_structure/volumetric/hashed_wavelet_octree.cc.o] Error 1
/home/alex/er/src/wavemap/libraries/wavemap/src/data_structure/volumetric/hashed_wavelet_octree_block.cc:3:10: fatal error: tracy/Tracy.hpp: No such file or directory
    3 | #include <tracy/Tracy.hpp>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/wavemap.dir/src/data_structure/volumetric/hashed_wavelet_octree_block.cc.o] Error 1
make[1]: *** [CMakeFiles/wavemap.dir/all] Error 2
make: *** [all] Error 2
cd /home/alex/er/build/wavemap; catkin build --get-env wavemap | catkin env -si  /usr/bin/make --jobserver-fds=3,4 -j; cd -

System information (please complete if relevant):

victorreijgwart commented 1 year ago

Thank you for reporting this bug and for opening a PR Alexander! I updated the tracy_catkin package to include install rules. Wavemap's CI pipeline now also includes a job to test that catkin builds in --install mode succeed. Hopefully, this will avoid similar issues in the future.

astumpf commented 1 year ago

Haven't tested it yet, but thanks for your awesome quick support!!

victorreijgwart commented 1 year ago

Welcome! Let me know in case any issues come up.