etternagame / etterna

Advanced cross-platform rhythm game focused on keyboard play
https://etternaonline.com/
MIT License
475 stars 134 forks source link

Mismatched pack zip/internal name or invalid pack names on site crash when downloading #762

Open MrLgeez opened 4 years ago

MrLgeez commented 4 years ago

here is the crash log

Etterna0.68.1 crash report (build )

Crash reason: Assertion 'opened' failed

Thread: Main thread GameSoundManager.cpp:615 2.943321, delta 0.002109 GameSoundManager.cpp:615 2.945430, delta 0.002026 GameSoundManager.cpp:615 2.947457, delta 0.002124 GameSoundManager.cpp:615 2.949580, delta 0.003001 DownloadManager.cpp:2372 Assertion 'opened' failed Thread: Decode thread RageSoundDriver_Generic_Software.cpp:235 Processing the sound while buffers are available. RageSoundDriver_Generic_Software.cpp:235 Processing the sound while buffers are available. RageSoundDriver_Generic_Software.cpp:235 Processing the sound while buffers are available. RageSoundDriver_Generic_Software.cpp:235 Processing the sound while buffers are available. RageSoundDriver_Generic_Software.cpp:235 Processing the sound while buffers are available. Thread: Mixer thread Thread: Music thread Thread: DirectInput thread InputHandler_DirectInput.cpp:884 InputHandler_DirectInput.cpp:860 InputHandler_DirectInput.cpp:878 InputHandler_DirectInput.cpp:884 InputHandler_DirectInput.cpp:860 debug resource file 'C:\Games\Etterna\Program\Etterna.vdi': CreateFile failed (The system cannot find the file specified.).

Static log: Etterna0.68.1 (build ) Log starting 2020-05-13 17:19:07 Verbosity: 1 Windows 6.2 (Win8) build 9200 [] WARNING: Main title or music file for '/Songs/Braeden's Megapack v2/DIAVOLO/' came up blank, forced to fall back on TidyUpData to fix title and paths. Do not use # or ; in a song title. Attempting to connect to: multi.etternaonline.com, Port: 8765 Server Version: 0 Video renderers: 'd3d, opengl' WARNING: RageDisplay_D3D::TryVideoMode( 1, 1920, 1080, 32, 64, 0 ) D3D Windowed 1920x1080 32 color 32 texture 64Hz NoVsync SmoothLines WARNING: Font import recursion detected WARNING: /Themes/Til Death/Fonts/_open sans semibold 24px.ini WARNING: /Themes/_fallback/Fonts/Common default.ini WARNING: /Themes/Til Death/Fonts/_16px fonts.ini WARNING: Current font: /Themes/Til Death/Fonts/_open sans semibold 24px.ini WARNING: Font /Themes/Til Death/Fonts/_16px fonts.ini has no characters Players joined: P1 Top Screen: ScreenPackDownloader Current renderer: Direct3D

Partial log: 00:08.739: Missing download link in packlist element: {"type":"pack","id":"88646","attributes":{"name":"RIFT IS DOWN SO I STEPPED 3 BAD SPEEDCORE FILES MINIPACK","average":25.1233,"download":"","mirror":"","size":0}} 00:08.739: Missing download link in packlist element: {"type":"pack","id":"88780","attributes":{"name":"Shadowpyre's Ascension Collection","average":16.0316,"download":"","mirror":"","size":0}} 00:08.739: Missing download link in packlist element: {"type":"pack","id":"87703","attributes":{"name":"Speed Training For SM Volume 4","average":27.0542,"download":"","mirror":"","size":0}} 00:08.739: Missing download link in packlist element: {"type":"pack","id":"88777","attributes":{"name":"SS 11th Style","average":12.1049,"download":"","mirror":"","size":0}} 00:08.739: Missing download link in packlist element: {"type":"pack","id":"88778","attributes":{"name":"SS 12th Style","average":14.22,"download":"","mirror":"","size":0}} 00:08.739: Missing download link in packlist element: {"type":"pack","id":"88455","attributes":{"name":"Stargroup's Sagittarius Minipack","average":15.145,"download":"","mirror":"","size":0}} 00:08.739: Missing download link in packlist element: {"type":"pack","id":"87705","attributes":{"name":"StarrySergal's Flamin Hot Munchies","average":15.394,"download":"","mirror":"","size":0}} 00:08.739: Missing download link in packlist element: {"type":"pack","id":"87710","attributes":{"name":"Trance EX Style's Simfile V2","average":21.5385,"download":"","mirror":"","size":0}} 00:08.739: Missing download link in packlist element: {"type":"pack","id":"88456","attributes":{"name":"Voltage","average":11.4697,"download":"","mirror":"","size":0}} 00:08.739: Missing download link in packlist element: {"type":"pack","id":"87712","attributes":{"name":"[DN03] Project A","average":0,"download":"","mirror":"","size":0}}

poco0317 commented 4 years ago

This should only happen when clicking an invalid download. At the moment this occurs for 2 known packs, one of them being the very first one. It's an instant crash. And it is a consistent crash. There's not a lot we can do from here to fix it, but the site can.

poco0317 commented 4 years ago

We can attempt to handle this in a different way, though. The reason it crashes is due to the filenames being different/invalid.