eu-digital-green-certificates / dgca-wallet-app-android

Repository for the dgca wallet app for android.
Apache License 2.0
58 stars 18 forks source link

[Android wallet app] - transfer a DCC via NFC is not received by the walletapp #167

Closed michawol closed 2 years ago

michawol commented 2 years ago

Describe the bug

if a DCC is sent from smartphine device A to smartphone device B via NFC, it does not arrive directly in the wallet app on device B. The sent file ends up in the file system of Device B and must first be imported.

Expected behaviour

a DCC sent via NFC should be received directly in the WalletApp

Steps to reproduce the issue

  1. select at device A a DCC and press "share pdf" or "Share image" button
  2. sent the DCC to Device B
  3. the DCC is not received by the walletApp

Technical details

WalletApp 1.2.8-tst (41) Xiaomi Mi Note 10 Lite

RalicaY commented 2 years ago

Issue persists in Android Wallet App 1.3.0 (41)

MykhailoNester commented 2 years ago

@RalicaY Fixed in: 1.3.2-(50)

ltranvan commented 2 years ago

tvt, 09.05.22: Retest failed. After clicking the NFC-ON-button in the the source-device (in the DCC) and the menu-item "Scan NFC code" on the Target-device, the user get a sand-clock in the target device with the message "NFC enabled", but nothing then happens (more than 5 minutes!!!).

MykhailoNester commented 2 years ago

@ltranvan could you specify your devices on which you tested? Also @Hendrik-Schmidt-Schierhorn-TSI could you check this build on your devices maybe it will work for you ?

MykhailoNester commented 2 years ago

@ltranvan did a quick test on my devices Pixel 3XL and Sumsung A52 Verifier: Version 1.3.2-tst-bloom (61) Wallet: Version 1.3.2-tst (50)

Check this video. Different devices have different nfc chip location. So If I hold this two devices near each other back side to front side of second device it will not work. Only when I hold them back to back.

https://user-images.githubusercontent.com/9447674/167568185-30bffb42-f9e3-499b-9036-f1e73a7e72cc.mp4

ltranvan commented 2 years ago

@MykhailoNester: the transfer-test per NFC was carried out between Samsung S10 and S21 FE 5G and both with the WalletApp version 1.3.2(50). Attention: the QR-certificate should be transfered from Wallet to Wallet as described above in ticket and NOT freom Wallet to Verifier :-) !

MykhailoNester commented 2 years ago

:) Yeah my bad I'll check it now, but NFC feature didn't work for all devices wallet/wallet and verifier/wallet and this fix in my PR should fix at least wallet/verifier connection now. I'll retest wallet/wallet

kerstin-oppermann-tsi commented 2 years ago

@michawol @RalicaY Please recheck with wallet 1.3.2-tst (51)

MykhailoNester commented 2 years ago

@ltranvan Fixed in build: Version 1.3.2-tst (51) Wallet/wallet dcc transfer works on my side now.

https://user-images.githubusercontent.com/9447674/167606636-76fc213c-87e0-4486-86ca-3e291633ce73.mp4

RalicaY commented 2 years ago

Test unsuccessful: origin device says "New tag detected" with empty screen and source device says "NFC enabled" on empty screen with rotating circle icon. Wallet App 1.3.2 (50)

ltranvan commented 2 years ago

tvt, 10.05.22: same test result like from Ralica was observed with my both devices S21 FE and S10. Please check. Thank.

MykhailoNester commented 2 years ago

@RalicaY it was fixed in 1.3.2-tst (51) not (50) Only 1.3.2.-tst(51) includes this fix.

When you scan with NFC check different position of devices. Same as on my video above. There might be one signal that disables check button and you need to enable it again. Also would be helpful to see video.

MykhailoNester commented 2 years ago

@ltranvan you also tested on build 50 ? please check if it was 51 as on my side it works video above ^. Scan both devices back side to back side. Different devices have different chip position.

ltranvan commented 2 years ago

No. i have tested it with 1.3.2 (51) on both side. But a new version 1.3.2 (52) is comming today and i will try it again and post its result here :-).

MykhailoNester commented 2 years ago

@RalicaY @ltranvan can you scan Wallet with DCC and enabled NFC feature with NFC Tools app from google play market?

Below attached result from old android 4.0 Samsung device which was able to scan this NFC tag from Wallet and you can see Record 1 has text from QR code. Can you check it, was is the result on your side.

Screenshot 2022-05-09 at 16 22 04
MykhailoNester commented 2 years ago

Latest build 52 contains all changes for NFC. Also works on my side.

MykhailoNester commented 2 years ago

Also during test check this configuration of QR code:

Screenshot 2022-05-12 at 17 39 54 Screenshot 2022-05-12 at 17 40 01
MykhailoNester commented 2 years ago

@RalicaY @ltranvan Fixed payload size limit in build Version 1.3.2-tst (53). Please retest with QR code above.

ltranvan commented 2 years ago

tvt, 13.05.22: Retested with Android-version 1.3.2-TST (53). NFC-Transfer from Samsung S21 FE to Samsung S10 works as expected.