search

eu81273 / angular.treeview

AngularJS based Treeview (no jQuery)
MIT License
405 stars 223 forks source link

added bower.json #44

Open bharat-dpd opened 9 years ago

bharat-dpd commented 9 years ago

as our module is already registered on bower. New user face some problem as may they don't know how to clone git repo with bower. For this i have added the bower.json file

bharat-dpd commented 9 years ago

As we know this is PURE angular module, there is no others dependencies. So I didn't get you by these line " currently fails to add required files". ᐧ

On Tue, Jul 14, 2015 at 1:45 PM, MrJean notifications@github.com wrote:

@eu81273 https://github.com/eu81273 Is it possible to merge this? When using automatic dependency wiring, it currently fails to add required files.

— Reply to this email directly or view it on GitHub https://github.com/eu81273/angular.treeview/pull/44#issuecomment-121162830 .

MrJean commented 9 years ago

@bharat-dpd When installing angular-treeview using Bower, automatic dependency wiring through wiredep (https://github.com/taptapship/wiredep) does not work because a bower.json is not defined and source files (JS/CSS) cannot be wired into source files of the project. See the Bower docs why I added the bower.json.

I know this module does not have dependencies but when using this module it becomes a dependency of the project where used. These are two different things.

bharat-dpd commented 9 years ago

this is because of our main key in bower file, I suppose not sure on this I have to dig more on it. ᐧ

On Tue, Jul 14, 2015 at 3:13 PM, MrJean notifications@github.com wrote:

@bharat-dpd https://github.com/bharat-dpd When installing angular-treeview using Bower, automatic dependency wiring through wiredep ( https://github.com/taptapship/wiredep) does not work because a bower.json is not defined and source files (JS/CSS) cannot be wired into source files of the project. See the Bower docs why I added the bower.json.

I know this module does not have dependencies but when using this module it becomes a dependency of the project where used. These are two different things.

— Reply to this email directly or view it on GitHub https://github.com/eu81273/angular.treeview/pull/44#issuecomment-121181643 .

MrJean commented 9 years ago

@bharat-dpd Obviously your pull request will not fix the problem because the files defined in your main field are incorrect. You are using dash notation, but it's actually dot notation.

This is my fork https://github.com/MrJean/angular.treeview and works like a charm when adding it as bower component

bharat-dpd commented 9 years ago

Ok you have removed "dependencies": { "angular": "~1.2.7" } key from bower.

If you allow I will remove this key form my fork also and make pull request again. ᐧ

On Tue, Jul 14, 2015 at 3:57 PM, MrJean notifications@github.com wrote:

@bharat-dpd https://github.com/bharat-dpd Obviously your pull request will not fix the problem because the files defined in your main field are incorrect. You are using dash notation, but it's actually dot notation.

This is my fork https://github.com/MrJean/angular.treeview and works like a charm when adding it as bower component

— Reply to this email directly or view it on GitHub https://github.com/eu81273/angular.treeview/pull/44#issuecomment-121194713 .