Isotopes Widget UI issues

eugenemel / maven

Maven GUI: Metabolomics Analysis and Visualization Engine

https://github.com/eugenemel/maven/releases

GNU General Public License v3.0

19 stars 10 forks source link

Isotopes Widget UI issues #380

Closed PMSeitzer closed 3 years ago

PMSeitzer commented 3 years ago

for instance, repainting() issues, and problems with managing the UI interaction of the isotopes widget with the EIC widget.

This might also be a good time to deal with the isotopes plot in the EIC widget.

PMSeitzer commented 3 years ago

From #349 :

Isotopes widget not always populating correctly. Isotopes widget does not respect the number of isotopes specified in the settings form - just continues to extract up to number of possible atoms substituted. Usage is partial/inconsistent. This was observed when trying to do the metabolomics portion of a D2O Analysis.

PMSeitzer commented 3 years ago

It appears that clicking on a peak once updates the isotopes widget. This could work well with #374 , where the selected area could be more clearly indicated on the eic widget.

PMSeitzer commented 3 years ago

It also appears that bookmarking isotopic peaks may cause the children to appear/disappear based on whether or not the peak group shown is the most recently added peak group (see #371 )

PMSeitzer commented 3 years ago

The isotopes widget is also responsible for the issue #371. This issue should be resolved/addressed at the same time #371 is handled.

PMSeitzer commented 3 years ago

In order to fix #371, the connection between the EICWidget and IsotopeWidget had to be severed.

[x] Reestablish connection between EICWidget and IsotopeWidget This has more or less been implemented as of 086d80841da37295293e57348e991de7f300a06e, however, more testing is required.
[x] Replace old IsotopeWidget::pullIsotopes() and BackgroundPeakUpdate::pullIsotopes() methods to use new PeakGroup::pullIsotope() method. Eliminated IsotopeWidget::pullIsotopes(), deprecated BackgroundPeakUpdate::pullIsotopes() and switched all usages to PeakGroup::pullIsotopes() as of 021e7d1ef973ef53979a72dbe3fb009e20659f35
[x] Save isotopeNumber field from PeakGroup into mzrollDB database. Completed as of 53840de1d036733786eb67e16f7833616375beab

PMSeitzer commented 3 years ago

Lots of progress as of 086d80841da37295293e57348e991de7f300a06e, however, still need to do some things:

[x] Manage selection of peakgroups within Bookmarks and other tables, specifically avoid triggering events/plotting for isotopic peaks This appears to be functioning correctly.
[x] Try to sort isotopic child peakgroups in a peakgroup by m/z, so that they always appear in the order where the first child peak group is the monoisotopic parent peak, and the last is the highest m/z isotope. This is somewhat dangerous, as sorting by the ID column can accomplish the same thing. Not implementing.