nus-pe-bot
commented
4 years ago Team's Response
One can argue that we should only check the name of the customer. However, many customers can have the same names. This is especially so if the customers do not give their surnames and only provide their first name. So we cannot only check the name of the customer.
Then one can say to check the phone number and name. This is what we did previously, however people have feedbacked that it is confusing that they can add two customers with same name and different phone numbers, but cannot add two customers with same name and different addresses. A suggestion was made to either just check the name of the customer or to check all fields (except tag).
As we cannot just check the name (refer to paragraph 1), we decided to check all fields (name, address, phone, email). Moreover, we chose to check all fields because we cannot decide whether address, phone number or email is the 2nd most important factor in distinguishing people (this is also why people were confused as mentioned in paragraph 2).
Hence, we believe that our stance of checking all fields is justified.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
:question: Issue type
Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
Seen below, people with the p/111 all appear in the find p/111. Checks should be performed to prevent the same phone number to be added by different entries.
Moreover, you may notice they all have the same name jackson. That's fine, because sometimes people only give first name. But, for fields like phone number, it should be unique because only 1 person can have 1 phone number.