eurofurence / ef-app_android

Eurofurence App (Android version)
MIT License
13 stars 5 forks source link

Conditional error on event fav #279

Closed Nesias closed 5 years ago

Nesias commented 6 years ago

Bug: Message "This event has already occured!" displayed if you try to fav an event and the time till start is less than than the alert time.

How to reproduce:

(Confirmed in 2 different Android devices)

Expected Result: Notice that no alert will pop up + event added to list.

Fenrikur commented 5 years ago

The issue occurs when the user tries to add an event to their favourites and the difference between the start time of the event and the current time is smaller than the number of minutes set for favourite alerts. This not only presents the user with the message mentioned above, but also prevents the event from being added to their favourites. It will most likely also prevent users from adding past or currently running events to their favourites as well, which may be considered unwanted behaviour.