evalEmpire / perl5i

A single module to fix as much of Perl 5 as possible in one go
http://search.cpan.org/perldoc?perl5i
Other
156 stars 42 forks source link

Update recommended autodie for better performance #284

Closed schwern closed 9 years ago

schwern commented 9 years ago

@pjf @nthykier

Given what @nthykier had to say about autodie being much faster and using less memory I think we should bump the version. I'd like to leave the required version alone, because performance isn't a requirement and 2.12 is the Debian stable version.

What would you recommend for the recommended version? 2.21 looks like it has the performance improvements. 2.26 has a bunch of bug fixes.

nthykier commented 9 years ago

Hi,

My take is v2.26 as recommended version.

The v2.23 and v2.24 fixes two outstanding bugs for autodie - namely weakening of the strict pragma and "no autodie" not respecting scope. The latter fix caused a weird issue during global destruction in some error cases and that was fixed in v2.26. The v2.26 release also fixes an annoying issue where a (sys)read/syswrite error could cause it to dump a binary buffer to STDERR (or logs). Finally, the "stacktrace" feature in v2.24 might be a useful sell.

Mind you, none of the problems fixed in v2.26 were (to my knowledge) introduced after v2.12, so none of them are regressions caused by the performance changes. Thus recommending v2.21 is an entirely valid solution on its own. It could make sense if you are aware of distros that only have an older version of autodie in their current or future version of a stable release. Though perl 5.20 ships autodie 2.23, so e.g. Debian Jessie will always supply a performance optimised autodie.

schwern commented 9 years ago

Okie doke, thanks for the input!