search

evancz / elm-todomvc

The TodoMVC app written in Elm, nice example for beginners.
http://evancz.github.io/elm-todomvc/
BSD 3-Clause "New" or "Revised" License
1.21k stars 329 forks source link

URL encode the "#" character in SVG data url #68

Open coryk135 opened 4 years ago

coryk135 commented 4 years ago

The todo-list checkbox SVG is not rendered in Chrome. Replacing the "#" character with the percent encoded value "%23" seems to fix the problem.

Most likely the same problem as this question and answer on Stack Overflow: https://stackoverflow.com/a/30733736

ZimbiX commented 4 years ago

This is a duplicate of PR https://github.com/evancz/elm-todomvc/pull/66, but I think is a more elegant fix due to less URL encoding required.

Fixes issue https://github.com/evancz/elm-todomvc/issues/65.

Confirmed working in latest stable Firefox and Chrome.

Nice one; LGTM :+1:

ZimbiX commented 4 years ago

Actually, I hadn't seen the note at this link from the other PR. Maybe IE/Edge do require the whole thing to be URL encoded. Could someone test on those please? =)