evanshultz / neater-bookmarks

A neater bookmarks tree popup extension for Chrome
https://chrome.google.com/webstore/detail/ofgjggbjanlhbgaemjbkiegeebmccifi
MIT License
215 stars 61 forks source link

Extensions suddenly take several seconds to open AND opens two tabs when middle clicking. #81

Open Vismund-Cygnus opened 7 years ago

Vismund-Cygnus commented 7 years ago

OS version: Windows 10 64-bit Chrome version: 55.0.2883.75 m (64-bit)

I've been using this extension for months. I fucking love it, since it lets me hide my Bookmarks Bar while also easily accessing my bookmarks. It's awesome.

But today, all of a sudden, it's started messing up.

First of all, when I click to open it, it takes several seconds to open. This has never happened before, it's always been instant. Strange.

Secondly, now when I middle-click a bookmark to open in a new background tab, it opens TWO TABS. This is crazy, I have NO idea why this would happen all of a sudden.

There was a new Chrome update last night, but I swear the extension was working fine after the update. I'm also sure I used the extension earlier today and it was working fine. But now as of about an hour ago when I got home and woke my PC back up, these two errors have started happening.

If it wasn't caused by the Chrome update and it wasn't caused by the extension updating (it hasn't been updated in 2 years*) then I have NO idea what the hell could have possibly caused this. Is anybody else experiencing this behavior??

Please let me know guys. Thanks

vespertinee commented 7 years ago

i have the same issue with the double tabs. didn't knew the dev abandoned the project, what a waste.

evanshultz commented 7 years ago

First, while I haven't updated the extension in quite some time I wouldn't consider it abandoned. There are a number of updates which I plan to do but won't be able to work on for a couple months yet. Notice how your speculation has turned into fact above.

Taking a long time to open must be a Chrome or PC issue. I don't see it on Win 10 on a few PCs I have on hand. Providing more info, like other extensions doing it, have you restarted Chrome or the PC, does it happen on multiple PCs, etc., would be the best way to troubleshoot.

With regards to multiple tabs, this is a Chrome issue. Google has broken this and then fixed it a couple times in the past, so my advice right now is to hold on and forgive Google for this issue. I can't say if this "bug" will be reverted, but if not I'll find a way to fix it once I get back to working on this extension. For what it's worth, this is still happening on Version 56.0.2924.14 dev (64-bit).

You-Schmuck commented 7 years ago

Hi there, just to add to this issue, the extension button only began acting sluggishly on updating from chrome 54 to 55, reverting to 54 fixes the issue, so something in the upgrade to 55 has changed something. I have done the usual stuff, reinstalling the extension, chrome, restarting the PC, all nada, the one and only thing that appears to cause the issue is chrome 55 itself, all other extensions have their usual behaviours, only NB has started acting delayed on button press to bring up the bookmarks list.

Just for clarity, system specs: Windows 10 Home 64-bit GTX 980 GPU Intel i7 3770K @ 3.6Ghz 16GB RAM Intel 520 240GB SSD

Chrome Version: 55.0.2883.75 m (64-bit)

Edit: On closer inspection after testing extension buttons in 54 and 55, it appears 55 itself is causing the sluggishness issue for ALL extension buttons, not just NB, so this may be something Google itself will have to hotfix, I'll file a bug in Chrome's issues section to see if it's a Chrome itself bug.

Vismund-Cygnus commented 7 years ago

First, while I haven't updated the extension in quite some time I wouldn't consider it abandoned. There are a number of updates which I plan to do but won't be able to work on for a couple months yet. Notice how your speculation has turned into fact above.

I'm sorry @evanshultz I really didn't mean to imply that it was in fact abandoned. I was just guessing based on the fact that the extension hadn't been updated in a while (not that it needed to be) and the fact that I didn't see any recent comments from you on this Github. I'm really glad to hear that you're still around! Even more excited to hear that there are updates down the road! =D

Taking a long time to open must be a Chrome or PC issue. I don't see it on Win 10 on a few PCs I have on hand. Providing more info, like other extensions doing it, have you restarted Chrome or the PC, does it happen on multiple PCs, etc., would be the best way to troubleshoot.

Yes, I realize now that this is happening for everybody on Chrome 55 and it happens on every extension icon, not just Neater Bookmarks. Kind of a bummer, but not related to this extension. And also not the biggest deal. The double-tab opening is the biggest issue for me, personally.

With regards to multiple tabs, this is a Chrome issue. Google has broken this and then fixed it a couple times in the past, so my advice right now is to hold on and forgive Google for this issue. I can't say if this "bug" will be reverted, but if not I'll find a way to fix it once I get back to working on this extension. For what it's worth, this is still happening on Version 56.0.2924.14 dev (64-bit).

Darn, that's a bummer. I'm not sure how easy this would be for you, but do you think it would be feasible to offer a quick fix? I think an easy way to fix this feature would be to offer a new variation of two of the current settings in the extension.

Left-clicking opens a bookmark in a new tab, which is great, but if you offered a setting that would allow left-clicked bookmarks to open in a background tab, instead of foreground, I think that would be a pretty good fix. That would enable the same function as middle-clicking but it wouldn't need to involve the middle-click button at all. As it stands now, when I left-click a bookmark it opens in a new foreground tab, moving you away from the tab you were in before. The "Popup stays open when opening (left-clicking) bookmarks" setting doesn't seem to work any more.

Do you think this would be possible to do in the meantime until Google fixes the issue or until you get back to working on the extension?

I'm just so persistent because like I said, I use this extension constantly. It has become ingrained in the way I browse and use the internet, and this new Chrome update screwing it up has really thrown me off.

I just thought I'd offer the idea of allowing middle-clicks to open in background tabs.

Thanks again, a TON, for making this great extension and also for responding here to let us know that you're still around and this extension isn't abandoned!

fallingup79 commented 7 years ago

Thanks for the awesome extension and the plans ahead, @evanshultz! :)

r2r2r2o commented 7 years ago

I am not chrome-ext dev but this issue was irritating me enough to get my hands dirty. I have found in Opera changelog interesting thing:

As mentioned above, the click event is no longer fired for non-primary mouse buttons. In most cases this is desirable; click event handlers are most often intended to handle primary clicks. But if you need to handle non-primary clicks (e.g., middle mouse button), the auxclick event can be used. The contextmenu event can also be used to handle clicks that would open a context menu (typically right-click).

And that lead me to: https://developers.google.com/web/updates/2016/10/auxclick

Thanks to that info, I was able to prepare a patch. Nevertheless, I have not tested it with any other browser than Opera 42! https://github.com/r2r2r2o/neater-bookmarks/commit/e8f5f5439b12ecac13976aeb48890a126ddaa6b1

Can anybody test it (especially, with the older version of chrome/opera)? Should I make pull request?

bubble2016 commented 7 years ago

我也有使用鼠标中键后台打开时,同时打开两个相同的标签页。希望开发者能够解决,在此感谢您的付出。

vespertinee commented 7 years ago

@r2r2r2o i would love to, but i don't have any idea how to apply it.

r2r2r2o commented 7 years ago

@vespertinee, Here is info you are looking for: https://blog.hunter.io/install-chrome-extension-manually/

You can download fixed code from; https://github.com/r2r2r2o/neater-bookmarks/archive/master.zip

vespertinee commented 7 years ago

@r2r2r2o it works great, thanks so much! using the version 55 of chrome in win10

bubble2016 commented 7 years ago

@r2r2r2o 谢谢你,很棒

choowkee commented 7 years ago

@r2r2r2o Thanks a lot for the fix. This is the only chrome extension that I know which supports middle mouse button tab opening in the background.

Vismund-Cygnus commented 7 years ago

@r2r2r2o you are my hero holy shit

sf-lee commented 7 years ago

Would @evanshultz please submit the fix from @r2r2r2o to Chrome Store?

Vismund-Cygnus commented 7 years ago

Maybe it's time to fork this into a new extension by somebody who has the time and knowledge to keep things working and add new features?

Sandriell commented 7 years ago

This is so infuriating. Having the fix above but Chrome won't let me use it without annoying popups everytime Chrome loads warning me about developer mode or out right disabling the extension every time. I would upload it to the store, but i'm not paying Google just to use this fix.

logicalup commented 6 years ago

@evanshultz it's been a year, Chrome hasn't fixed it. Any chance you can implement the fix from @r2r2r2o?

CADbloke commented 6 years ago

I replaced it with https://chrome.google.com/webstore/detail/popup-my-bookmarks/mppflflkbbafeopeoeigkbbdjdbeifni

spuffler commented 5 years ago

Coming up on 2 years since Vismund-Cygnus commented on Dec 2, 2016.

Nudge nudge.

Confirming middle click currently creates two tabs.

Slimjet on Linux: "Slimjet Version 19.0.4.0 (based on Chromium 66.0.3359.117) (Official Build) (64-bit)"