coderabbitai[bot]
commented
3 months ago Walkthrough
The changes primarily involve enhancements to transaction handling within the application. This includes the addition of a BankKeeper to the HandlerOptions struct, updates to the test suite to incorporate new mocks for the bankKeeper, and the removal of the FeeGrantKeeper from post-handler options. Additionally, the go.mod file has been updated with new dependencies and version changes to improve the overall dependency management.
Changes
| Files | Change Summary |
|---|---|
| app/ante/ante.go | Added BankKeeper to HandlerOptions; updated NewAnteHandler to include BankKeeper in fee market logic. |
| app/ante/ante_test.go | Modified TestMempoolDecorator to mock bankKeeper, added test account creation, included additional dependencies in FeeMarketCheckDecorator. |
| app/ante/suite.go | Updated bankKeeper to use feemarketmocks.BankKeeper; changed setup functions for improved mock fidelity. |
| app/app.go | Removed FeeGrantKeeper from PostHandlerOptions in setPostHandler and NewPostHandler functions. |
| go.mod | Updated Go toolchain version and added new dependency: github.com/stretchr/objx v0.5.2. |
Possibly related PRs
- #250: This PR modifies the
HandlerOptionsstruct inapp/ante.goby adding aFeeMarketKeeper, which is closely related to the changes in the main PR that also involves modifications to theHandlerOptionsstruct and theNewAnteHandlerfunction, specifically with the addition of theBankKeeper.
Suggested reviewers
- minhngoc274
Poem
🐇 In the world of code, so bright and new,
Changes are hopping, like morning dew.
BankKeeper's here, to manage the flow,
Fee grants now gone, as we let go.
With mocks and tests, we've set the stage,
A leap for the app, as we turn the page! 🌼✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This is the blackberry fee market fix.
I didn't write this code, just added a commit to #275
Thanks to Skip!
Summary by CodeRabbit
BankKeeperfor better banking operations management.bankKeeperinteractions.FeeGrantKeeperfrom post-handler logic, indicating a shift in fee management processes.