search

event-driven-io / emmett

Emmett - a Node.js library taking your event-driven applications back to the future!
https://event-driven-io.github.io/emmett/
195 stars 19 forks source link

feat(docs,emmet-expressjs): add e2e api specification #29

Closed thiagomini closed 8 months ago

thiagomini commented 8 months ago

Closes #26

Hey @oskardudycz , I haven't added the ES db yet because I'm unsure how to replace the inMemoryStore(). However, I believe this draft may suffice as an initial discussion for that issue. It took me some time to figure out how everything worked and glued together, but I feel I'm understanding the architecture better now 😅

One thing I'd like to ask / discuss is the no-unsafe-assignement rule that we're using here and it's complaining all over the place - is this intended? Honestly, in many cases it doesn't make sense, look at this example:

image

The getInMemoryEventStore() function has a defined return value, yet this rule is complaining 🤔

Anyway, let me know what you think about this initial implementation!

oskardudycz commented 8 months ago

Regarding the lint errors, in my case for VSCode restarting the ESLint server fixes issue (and it's a "known issue" on their side, see https://discord.com/channels/1211601942984532018/1211601943433060433/1213043016512573480 :|). For ts, it's not but might be that's mishap on my side configuring paths. I'll try to look into that.