eventuate-clients / eventuate-client-java

Eventuate Java client
Other
53 stars 31 forks source link

Clarify status of eventuate-client-java-tests #25

Closed cer closed 4 years ago

cer commented 4 years ago

https://github.com/eventuate-clients/eventuate-client-java/blob/3337ec8d41ad1e819949d4cdb6171b498c263788/settings.gradle#L32-L33

dartartem commented 4 years ago

Tests were turned off by this commit: https://github.com/eventuate-clients/eventuate-client-java/commit/aa94b62a72b9643fbec31ab5d844917d084e4c66

I enabled them, fixed some compile-time issues and got these failed tests:

Error:

Caused by: org.springframework.validation.BindException: org.springframework.boot.bind.RelaxedDataBinder$RelaxedBeanPropertyBindingResult: 2 errors
Field error in object 'eventuate' on field 'apiKeySecret': rejected value [null]; codes [NotBlank.eventuate.apiKeySecret,NotBlank.apiKeySecret,NotBlank.java.lang.String,NotBlank]; arguments [org.springframework.context.support.DefaultMessageSourceResolvable: codes [eventuate.apiKeySecret,apiKeySecret]; arguments []; default message [apiKeySecret]]; default message [may not be empty]
Field error in object 'eventuate' on field 'apiKeyId': rejected value [null]; codes [NotBlank.eventuate.apiKeyId,NotBlank.apiKeyId,NotBlank.java.lang.String,NotBlank]; arguments [org.springframework.context.support.DefaultMessageSourceResolvable: codes [eventuate.apiKeyId,apiKeyId]; arguments []; default message [apiKeyId]]; default message [may not be empty]

It seems test module is excluded because aws server is not available.

cer commented 4 years ago

Please update the comment to reference this issue.

dartartem commented 4 years ago

Chris, what comment should I update? "this issue" == https://github.com/eventuate-clients/eventuate-client-java/issues/25 right?

cer commented 4 years ago

The comment that this issue is about: https://github.com/eventuate-clients/eventuate-client-java/blob/3337ec8d41ad1e819949d4cdb6171b498c263788/settings.gradle#L32-L33

dartartem commented 4 years ago

Got it

dartartem commented 4 years ago

https://github.com/eventuate-clients/eventuate-client-java/pull/26