erosb
commented
8 years ago Hello @ujibang !
It seems to be 2 more or less separate problems. If CombinedSchema.succeeds()gets even executed then the schema loading itself succeeded, so the StackOverflowError has nothing to do with the schema loading process. It would be very helpful if you could send me inputs (schema and example document to be validated) for simply reproducing this bug.
"even if I pass the child schema to the SchemaLoader.load() method, the SchemaClient seems loads child again via http"
I'm not sure what is the expected behavior in your case. I'll dig into the relevant sections of the schema spec 7.2.2 - 7.3.3 .
Edit:
So your resolution scope is "http://127.0.0.1:8080/yaala/_schemas/child#" and you refer to an other schema using the string "parent", and
- you expect it to refer to the schema
http://127.0.0.1:8080/yaala/_schemas/parent# - while the schema validator downloads
http://127.0.0.1:8080/yaala/_schemas/child#parent - and according the the "alsonested" example in section 7.2.2, it should refer to
http://127.0.0.1:8080/parent#
We are both wrong :) To be honest I never liked the remote schema handing of the json schema specification, it is quite blurry, illogical and hard to understand.
I'll look after this issue in the code.
ujibang
balazs-zsoldos
I have defined two schemas. One extends the other using allOf and $ref
When I try to validate a json document I get StackOverflowError exception.
I have done some debugging and even if I pass the child schema to the SchemaLoader.load() method, the SchemaClient seems loads child again via http. I think it should load parent instead.
Test document passed to validate:
parent schema
child schema
Exception