search

everwatchsolutions / json-data-generator

A robust, generic, streaming random json data generator for your data
Apache License 2.0
397 stars 176 forks source link

Print more than one json in FileLogger #52

Open pandid opened 6 years ago

pandid commented 6 years ago

We needed to extend the functionality of the FileLogger. Originally it writes just one json object in a file and then moves to the next. If one wants to create big number of such objects this approach not feasible. We added "file.lines". The current functionality is handled by setting "file.lines" to 1 or say "file.lines":"1000".

Commits added functionality to add print more than one json object per file in FileLogger.

rjperry611 commented 5 years ago

This is good. My team will need this functionality as well. Once your PR is accepted by everwatch, I think I'm going to extend it a little bit further by adding the option for timestamp based roll ups as well.

andrewserff commented 5 years ago

Sorry for the very long delay on reviewing this. This seems like a good idea, but could you make it default not require the new file.lines? i.e. default it to one if it's not set? And then update the README with the new option?

Thanks for the contribution!