everycook / EveryCook

The worlds best recipe database
32 stars 6 forks source link

Edit recipe #64

Closed everycook closed 11 years ago

everycook commented 12 years ago

Just wanted to edit the risotto recipe and I see only the first 4 steps.

probably because of my DB changes...

swerder commented 12 years ago

I fixed the data of recipe, and the handling of showing data, so now it work again.

everycook commented 12 years ago

tested. works.

everycook commented 12 years ago

we need fo simplify input values: -for the weight make a pulldown to input kg or g with some JS that does conversion. anf if we have this I guess it is peanuts to add US weight units. see: http://en.wikipedia.org/wiki/United_States_customary_units oz/lb is enough...

And the for the time please make a pulldown with h and m. m should be default

you can hardcode this. use abbreviations so we don't have to translate it.

you can hardcode this. no need for a DB table as it

swerder commented 12 years ago

US fl. oz. can be calculated to ml, but we currently only have g (gramm) as unit, because its a weight not a volume... --> 1 ounce (oz) 28.349523125 g

for time is there h and m enough doesn't it need also s? otherwise the smallest value would be 1 minute. what do you need in the firmware for the time fields? is it minutes? seconds? --> s will be saved, m shown.

swerder commented 12 years ago

weight / time dropdowns added. saving recipes now work again.

There are currently no check if all step fields are filled (because of different changes/optimizing).

On changing the StepType, should than all default values from config set to fields, or only if they doesn't exist on last stepType / was empty?

everycook commented 12 years ago

Only if not yet existing.

swerder commented 12 years ago

check required fields for step added again.

everycook commented 12 years ago

For the entrecôte recipe I had a problem. It says "turn around obejectofaction" and then I have to select an ingredient. but since I already added the meat I set the weight to 0. in the ingredient list it says entrecote 2 times.

so we need to check, that ingredients appear only once (are summed up) in ingredient list even when they are a added several times to the meal.

swerder commented 12 years ago

done.

everycook commented 12 years ago

Just some details: the "choose ingredient" button should be colored, it is nearly invisible now. And when an ingredient is chosen we should replace the #objectofaction with "Ingredient" and I created remove/up/down buttons. mailed them to you, please integrate them...

swerder commented 12 years ago

The choose Template function is implemented, also with other data than steps. But data are only in browser, not yet in Backend, on refresh in browser data is the on in last save/submit. Expected from this Logik is the image, this must be set in Brackend to show it, and therefore already set in Backend.

Choose ingredient is now in button style. The 3 images are included.

the point with replacing #objectofaction is a bit tricky, because have to "reset" it when ingredient will be changed. So I want to change this logic only once: Should I replace it with ingredient, or with ingredient and weight? (as in cook assistant) perhaps we should change the description to #objectofaction# #weight#, and weight is only needed if it is in text like this. For example in "Turn over #objectofaction#" the weight would not make any sense...

everycook commented 12 years ago

The template works. it's ok to have the data only in the browser until the user saves it... choose ingredient button is good.

the 3 images are invisible to me... in ff&chrome... did not find them in the pics folder so I uploaded them. but still invisible...

if the replacement is complicated we will do it later. we have more urgent stuff...

swerder commented 12 years ago

images fixed, it was a not uploaded css change.

everycook commented 12 years ago

If I create a "heatup" or a "cook" step I can't set tepm or press... not so good...

swerder commented 12 years ago

if you choose the steptype, it work. if you only select the text (action) then the field will to shown.

I could remove the Actons for the stepstypes from the action list. or can select the step type automaticale if you select the action.

say what you want, to remove the confusion you had here.

swerder commented 12 years ago

Recipe Editor adapted to new DB-Structure (ActionsIn / ActionsOut)

everycook commented 11 years ago

The mise-en-place (preparing all ingredients before starting) needs a concept. thinking...

EDIT: I created steps for preparing ingredients that not need scaling.

everycook commented 11 years ago

which order for input fields?

everycook commented 11 years ago

Input fields: Line 1: Action_in, Ingredient, Grams Line 2: Step_Duration, Step_Celsius/kPa (if needed, ony one at a time), Line 3: Ste_RPM, Ste_Run, Ste_Pause

did I forget sth?

everycook commented 11 years ago

I adapted the ribeye recipe and it had no delicious/disgusting/cook buttons. I tried to add it to the menu planner, i could add it, saw it saved and then it was gone. risitto can be added to plan, ribeye can't.

I tried creating a new ribeye, but faced the same problems. (that's why we have a ribeye(broken) and a ribeye...)

just noticed that the same happens with your roasted onions

swerder commented 11 years ago

I fixed the bug with meal planer 7 months ago, I checked in the change (d2c2cf18672f608190eb0f61febb5d50dd839b88) but did not upload the files... It is a failure with different Database (priv & normal) I must change the default handling in /lib/yii/framework/db/ar/CActiveFinder.php

swerder commented 11 years ago

input fields order done. I added the tool field after action in, as it was before.

everycook commented 11 years ago

needs usability improvements (which I have to define) but works