evilhero / mylar

An automated Comic Book downloader (cbr/cbz) for use with SABnzbd, NZBGet and torrents
GNU General Public License v3.0
977 stars 173 forks source link

Crossed Badlands post-processing always failing #814

Closed SebNYD closed 9 years ago

SebNYD commented 10 years ago

Hello,

I initially thought that something was wrong with the files, but it doesn't seem to be the case. Mylar works very well for me except when a new issue of Crossed badlands is downloaded. Everytime the postprocessing fails (I'm on Windows 7).

Could you try to add this comic and tell me if the same thing happens to you ?

Thanks,

Seb

evilhero commented 10 years ago

(I'm on ubuntu 12.04) I was able to add the series, and search for the last 3 issues. Issue 58 was the only one that downloaded and post-processed successfully. It couldn't find issue 60, and the 2 tries it attempted for issue 59 were marked as Failed (since they failed to extract when it was performing meta-tagging).

Edit. Just tried this on Windows 8, latest development build, same as above - although it couldn't find issue 60 due to some weird store date, but it tried to grab issue 59 - failed as they were tagged as being corrupt, and 58 it grabbed fine and post-processed.

What are the logs say showing your post-processing failing ?

SebNYD commented 10 years ago

Here is the log for issue 60 : 01-sept.-2014 22:45:55 - INFO :: CP Server Thread-5 : Starting postprocessing for : Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire) 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] nzb name: Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire) 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] nzb folder: D:\Multimedia\Lecture#Temp\Comics\Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire) 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] After conversions, nzbname is : Crossed.-.Badlands.060.(2014).(4.Covers).(Digital).(Darkness-Empire) 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] Issueid: 463609 01-sept.-2014 22:45:55 - INFO :: Post-Processing : [POST-PROCESSING] issuenzb found. 01-sept.-2014 22:45:55 - INFO :: Post-Processing : [POST-PROCESSING] Starting Post-Processing for Crossed Badlands issue: 60 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] issueid: 463609 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] issuenumOG: 60 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] Zero Suppression set to : none 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] Pretty Comic Issue is : 60 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] Issue Year : 2014 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] Publisher: Avatar Press 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] Series: Crossed Badlands 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] Year: 2012 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] Comic Location: D:\Multimedia\Lecture\Comics\Crossed Badlands (2012) 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] Comic Version: None 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] No version # found for series, removing from filename 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] New format is now: $Series $Issue ($Year) 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] Not an annual - removing from filename paramaters 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] New format: $Series $Issue ($Year) 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [POST-PROCESSING] Metatagging enabled - proceeding... 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] dirName:D:\Multimedia\Lecture#Temp\Comics\Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire) 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] Paths / Locations: 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] scriptname : Mylar.py 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] downloadpath : D:\Multimedia\Lecture#Temp\Comics\Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire) 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] sabnzbdscriptpath : C:\Program Files (x86)\mylar 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] comicpath : D:\Multimedia\Lecture#Temp\Comics\Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire)\temp 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] unrar_folder : D:\Multimedia\Lecture#Temp\Comics\Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire)\temp\unrard 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] Running the ComicTagger Add-on for Mylar 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] Attempting to create directory @: D:\Multimedia\Lecture#Temp\Comics\Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire)\temp 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] Created directory @ : D:\Multimedia\Lecture#Temp\Comics\Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire)\temp 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] Filename is : None 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] Mylar.py: converting Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire).cbr to be zip format 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] {0}: Comicpath is D:\Multimedia\Lecture#Temp\Comics\Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire)\temp\Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire).rar 01-sept.-2014 22:45:55 - DEBUG :: Post-Processing : [META-TAGGER] {0}: Unrar is D:\Multimedia\Lecture#Temp\Comics\Crossed - Badlands 060 (2014) (4 Covers) (Digital) (Darkness-Empire)\temp\unrard 01-sept.-2014 22:45:56 - WARNING :: Post-Processing : [META-TAGGER] Marking this as an incomplete download. 01-sept.-2014 22:45:56 - ERROR :: Post-Processing : [POST-PROCESSING] This is a corrupt archive - whether CRC errors or it is incomplete. Marking as BAD, and retrying a different copy. 01-sept.-2014 22:45:56 - INFO :: CP Server Thread-5 : Initiating Failed Download handling 01-sept.-2014 22:45:56 - INFO :: CP Server Thread-5 : Initiating Failed Download handling for this download. 01-sept.-2014 22:45:56 - DEBUG :: FAILED Post-Processing : [FAILED-DOWNLOAD] After conversions, nzbname is : Crossed.-.Badlands.060.(2014).(4.Covers).(Digital).(Darkness-Empire) 01-sept.-2014 22:45:56 - DEBUG :: FAILED Post-Processing : [FAILED-DOWNLOAD] Issueid: 463609 01-sept.-2014 22:45:56 - INFO :: FAILED Post-Processing : [FAILED-DOWNLOAD] Provider: nzb.su 01-sept.-2014 22:45:56 - INFO :: FAILED Post-Processing : [FAILED-DOWNLOAD] ID: [API].nzb&i=[KEY]&r={apikey} 01-sept.-2014 22:45:56 - INFO :: FAILED Post-Processing : [FAILED-DOWNLOAD] issuenzb found. 01-sept.-2014 22:45:56 - INFO :: FAILED Post-Processing : [FAILED-DOWNLOAD] Successfully detected as : Crossed Badlands issue: 60 that was downloaded using nzb.su 01-sept.-2014 22:45:56 - INFO :: FAILED Post-Processing : [FAILED-DOWNLOAD] Marking as a Failed Download. 01-sept.-2014 22:45:56 - INFO :: FAILED Post-Processing : [FAILED-DOWNLOAD] Successfully marked as Failed. 01-sept.-2014 22:45:56 - INFO :: FAILED Post-Processing : [FAILED-DOWNLOAD] Stopping search here as automatic handling of failed downloads is not enabled hint

evilhero commented 10 years ago

First download was a corrupt archive which gets detected when Mylar has to convert the cbr to cbz for metatagging. It then gets marked as Failed, and Mylar attempts to do another search for a different result but stops. Because you don't have Failed Download handling enabled it stops the post-processing.

Have you tried opening the cbr file to see if you can view it, if you're saying the files are not corrupt.

SebNYD commented 10 years ago

But that's just it, the file is not corrupt.

Regarding the fact that the Failed handling is disabled, it's be cause the very same thing happened with issue 59 and Mylar kept retrying again and again (90 nzb were sent to SAB !), so I had no choice but to disable that feature :)

evilhero commented 10 years ago

Is it just Badlands that doesn't process? You'd have to open every image in the archive to make sure that it's not corrupt (or read the file in your Comic reader from start to finish).

If it occurs for every series, then it would be a coding problem for sure, but if it's only happening with this one series it honestly is probably due to the nzb being grabbed that is bunk.

Have you tried manually post-processing the issue that Mylar says is corrupt but it's not?

SebNYD commented 10 years ago

Yes, this only happens with Crossed Badlands and it's been a while oddly.

When reading these issues, I don't see anything wrong inside.

I did the post processing with ComicRack (Convert to CBZ then get Metadata) and got no warning, it just worked.

That's not so bad but it's really weird :)

evilhero commented 10 years ago

Yeah it is weird if it's just the one series, and I honestly don't know why it would be failing other than the invalid JPG's inside.. Mylar just does a simple 'unrar x' command to test the integrity.. Hmm.. Can you verify your version of unrar that you're running?

It would be nice if this would just work like the others, so it's a bit of a head scratcher.

I did notice something unrelated - the failed Id that Mylar stores when failed Download handling happens is incorrect (it's storing your api key), so I'll look into that as well..

Have you tried another provider aside from nzb.su?? Even experimental might yield different results since they go through different download calls.

SebNYD commented 10 years ago

Regarding providers, Dognzb and Experimental have also been for issue 58 and 59 (Failed PP also).

I have WinRAR 4.2, I'll try to update and see what happens :)

SebNYD commented 9 years ago

It seems that simply upgrading WinRAR version did the trick :)

Thanks,