Open sanmai-NL opened 1 year ago
We decided to keep arm64
for ARM 64 architectures, so please, use uname -m | sed 's/aarch64/arm64/
. This is because on macOS uname -m
returns arm64, and on Linux it is aarch64. The decision was made a long time ago, and I don't want to change this to not break the things.
But I can probably add an artifact with aarch64 name in new releases. Do you feel OK about it?
The suffix can be Linux-only, no?
@mrexox adding a duplicate artifact is fine. What about migrating to the new suffix scheme for new releases only? How would that break things?
It probably won't break things if other people don't rely on this of course. So, you suggest to change the artifact lefthook_1.5.2_Linux_arm64 to lefthook_1.5.2_Linux_aarch64
, right?
Well that but only for future releases, if needed.
:zap: Summary
The hardware platform suffix for Linux builds is now
amd64
orarm64
. Change this for more reliable automation in provisioning.Value
Make container builds work with automated fetching of the released Lefthook executable, even under virtualized Linux such as Docker Desktop, Rancher Desktop, Podman Desktop on MacOS.
Behavior and configuration changes
The problem:
Follow
uname -m
as hardware platform suffix. So that this script works: