search

evoluteur / evolutility-server-node

Model-driven REST APIs for CRUD and more, written in Javascript, using Node.js, Express, and PostgreSQL.
GNU Affero General Public License v3.0
111 stars 33 forks source link

Chart handles missing data inconsistently #14

Closed david-pfx closed 5 years ago

david-pfx commented 5 years ago

The chart API grouping differs by field type.

My preference would be to group them in an 'Unknown' category, but at least they should be consistent.

evoluteur commented 5 years ago

It may not be consistent in the way a DBA would look at it but it is consistent with the UI because that is what users will expect. For boolean fields nulls are the same as false b/c checkboxes treat them the same. LOV fields use a left join so null and invalid keys fall into the same N/A bucket as dropdowns will show empty. The "Unknown" group is called "N/A".

evoluteur commented 5 years ago

On second thought, if the user is a data scientist or a DBA he may want the charts to differentiate b/w null and false for boolean... Ideally there should be new config options for charts.

david-pfx commented 5 years ago

Yes, I think that would be preferable. But consistency in treatment was my main concern.

Regards

David M Bennett FACS

Puzzlang – Pattern language and Unity player for abstract single-player games and puzzles -- http://www.polyomino.com http://www.polyomino.com/

From: Olivier Giulieri [mailto:notifications@github.com] Sent: Thursday, 29 November 2018 5:37 PM To: evoluteur/evolutility-server-node evolutility-server-node@noreply.github.com Cc: david-pfx david@polyomino.com; Author author@noreply.github.com Subject: Re: [evoluteur/evolutility-server-node] Chart handles missing data inconsistently (#14)

On second thought, if the user is a data scientist or DBA he may want the charts to differentiate b/w null and false for boolean... Ideally there should be new options in the config for charts.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/evoluteur/evolutility-server-node/issues/14#issuecomment-442722871 , or mute the thread https://github.com/notifications/unsubscribe-auth/AMLCXaYcfSsqPQ3Ivi4VQ91RB50bx09bks5uz4BzgaJpZM4YsV77 .