exadel-inc / CompreFace

Leading free and open-source face recognition system
https://exadel.com/accelerator-showcase/compreface/
Apache License 2.0
5.72k stars 776 forks source link

Add to .env file "max_detect_size" option #609

Closed pospielov closed 3 years ago

pospielov commented 3 years ago

To improve performance on huge images, we resize it before face detection. The downside of this is that small faces could be not recognized.

Some users complain that we do not catch too small faces in their 1080p camera.

We need to make resizing a configurable variable, so users choose if we need to resize at all, or what resize to apply

Here is where we init the variable in Python: https://github.com/exadel-inc/CompreFace/blob/c44c92eaea31798f8e68c91acc36144d3b8ab411/embedding-calculator/src/constants.py#L24

So basically all we need is to add the "IMG_LENGTH_LIMIT" environment variable to docker-compose and then add it to .env file

deepto98 commented 3 years ago

@pospielov Hi, I'd like to work on this issue, can you assign this to me?

pospielov commented 3 years ago

Hi, thanks for the interest in our repository, I assigned the issue to you

sheetal2001p commented 3 years ago

Hi ,I just want to start my open source contribution through hactoberfest but I am a beginner and don't know much about how can I contribute!! so it is the issue for beginners right? So please can anyone help me how can I able to solve this issue ? Is it necessary to be assigned to me?

pospielov commented 3 years ago

Hi, thanks for the interest in our repository. I assign tasks to people because there is no reason two people work on one issue in parallel. Please, check the list of issues that are not assigned to anybody. Also, I'll try to add more issues for beginners during a couple of days.

Onyinye91-ctrl commented 3 years ago

@pospielov is there any first time issues you can assign to me?

pospielov commented 3 years ago

Hi @Onyinye91-ctrl https://github.com/search?q=label%3Ahacktoberfest+org%3Aexadel-inc&type=Issues here is a list of open issues in our repositories. You can choose any open issue that is not assigned already Also, would you like a very simple or challenging issue? What technology do you prefer?

sheetal2001p commented 3 years ago

Hi @Onyinye91-ctrl https://github.com/search?q=label%3Ahacktoberfest+org%3Aexadel-inc&type=Issues here is a list of open issues in our repositories. You can choose any open issue that is not assigned already Also, would you like a very simple or challenging issue? What technology do you prefer?

Yes actually I want some simple issues related to javascript(Reactjs or nodeJs etc.)

potap75 commented 3 years ago

@pospielov the best solution is to automatically check what the minimum acceptable resolution is. and then either resize to that resolution or tell the user "Sorry, the image cannot be smaller bla bla..."

Onyinye91-ctrl commented 3 years ago

Thank You @sheetal2001p @pospielov

pospielov commented 3 years ago

@sheetal2001p Looks like all JavaScript tasks are taken in CompreFace repository I'll try to find more tasks, but it looks like I already added all simple tasks Please look at another Exadel repository: https://github.com/exadel-inc/esl

pospielov commented 3 years ago

@potap75 Hi, I didn't get your idea, how we can automatically check the minimum acceptable resolution? I mean in production somebody will put a camera on the level of the face, so the person will need to come near the camera and it will open the door. And somebody will put the camera somewhere on the ceiling, just to calculate a number of visitors. So the face size in those options will be very different

pospielov commented 3 years ago

Hi @deepto98, just wanted to know if you have any issues with the completion of this task. If you don't want to work on it anymore, please notify me, so I'll assign it to other contributors.

pospielov commented 3 years ago

Deassigned @deepto98 because of ignoring the task for 18 days.

pospielov commented 3 years ago

@sheetal2001p do you want to take this issue?

sheetal2001p commented 3 years ago

@sheetal2001p do you want to take this issue?

yeah sure. Assign it to me

pospielov commented 3 years ago

Assigned :)

pragyag15 commented 3 years ago

Hi, I'd like to work on this issue, can you assign this to me?

sheetal2001p commented 3 years ago

@pospielov please review my pull request.

pospielov commented 3 years ago

Merged, thanks for the contribution!