search

excalibur1234 / pacui

Bash script providing advanced Pacman and Yay/Pikaur/Aurman/Pakku/Trizen/Pacaur/Pamac-cli functionality in a simple UI
GNU General Public License v3.0
168 stars 13 forks source link

kernel-check/available_kernels: use pacman search only #27

Closed thefallenrat closed 6 years ago

thefallenrat commented 6 years ago

This make available_kernels to check if installed_kernels are available in repositories and forward it to available_kernels itself Thus removing grep command completely

Signed-off-by: Rafli Akmal rafliakmaltejakusuma@gmail.com

PS : Sorry If I opened another pull request :(((

Chrysostomus commented 6 years ago

+ no temporary files (hopefully less error prone) + more distro independent - gives false warnings if user shares /boot between distros

Sharing /boot happens mainly when people mount their esp to /boot in uefi systems. It is bad practice in multiboot systems, but for example systemd-boot practically requires, as does using refind with encryption unless you use manual boot stanzas.

Is this a scenario that should be taken into account?

thefallenrat commented 6 years ago

* Please forgive me for my lack of knowledge

Sharing /boot happens mainly when people mount their esp to /boot in uefi systems. It is bad practice in multiboot systems, but for example systemd-boot practically requires, as does using refind with encryption unless you use manual boot stanzas.

Did you mean that vmlinuz files from any kernel packages will be not in /boot folder if the system was UEFI?

If the case was there are vmlinuz* files from other distros in /boot besides from arch, then there's no need to do anything as pacman will outputs nothing if -Qo option was run with that file....

Chrysostomus commented 6 years ago

Just reread the chamges, it is indeed unproblematic because the aim is to simply test if there is any supported kernel left. The false positives would be generated with this method only if we were trying to see if there is any unsupported kernel.

excalibur1234 commented 6 years ago

thanks for your continued work!

while i was offline, i continued to improve pacui. i have just pushed 17 commits and will merge your PR soon.

because of the new AUR package list format, i have to release a stable version soon. not much time for looking for bugs...

btw, do @thefallenrat and @Chrysostomus want push access to pacui? then, you will be able to fix bugs even without me being around (and it is less cumbersome to commit).

excalibur1234 commented 6 years ago

oh darn. this PR was for the "devel" branch. because of the latest changes i have added to the master branch, the devel branch is now incompatible to the master branch. therefore, i have merged your code manually here: 9d0a086ad0cfdcd60f7b089ba1ab54efc7a22ed4 sorry for that.