Closed unveiled closed 6 years ago
thanks for your tip.
i applied it in the latest patch: https://github.com/excalibur1234/pacui/commit/edb44978317f0641a473f3b751be8ef32346356a
exporting the SHELL variable is not really necessary - at least according to my tests. does it work for you, too?
Yep. I just assumed it needed to be exported in order to apply to subprocesses, but I just tested the latest patch and it works.
fzf --preview
spawns a new process. It appears that this new process honors theSHELL
env variable, so that if a user has fish as their shell, then the spawned process chokes on what the alternative shell sees as invalid syntax/commands.I can correct this for myself by wrapping the call to pacui:
bash -c 'export SHELL=/usr/bin/bash; pacui'
But I think pacui can correct this itself by putting
export SHELL=/usr/bin/bash
anywhere before the first call tofzf --preview
. I tested this. It worked and I didn't see any negative side-effects.