search

excellarateinc / voyage-api-dotnet

Enterprise grade C# .NET Web Services API implementing industry standard best practices
Apache License 2.0
16 stars 14 forks source link

Notifications Api #131

Closed raymer closed 7 years ago

raymer commented 7 years ago

Basic notifications API with unit tests.

roblouie commented 7 years ago

Only question on this is should be be using web sockets for this? Depends how real-time we want these to be I guess. If we just want them to like update every 30 seconds or something then I think standard rest style is fine. This my have already been discussed, I've just been in select account world and wasn't sure.

maniphanh commented 7 years ago

What do you think about using SignalR instead of API? SignalR supports web socket, server sent and long pulling depending on user's browser it can fall back to different transport. To my understanding notification is arming toward real time than API. SignalR is one of the most popular real time notification framework for Microsoft stack. If this going to be in Voyage Core I think we should consider it

raymer commented 7 years ago

Hey guys, I didn't implement websockets (SignalR) because I didn't want to add complexity unless we really want to support real-time push notifications. I thought the simplest approach for now was to poll the endpoint at some interval. If we think that we want to go the real-time push route, I'll throw an issue in Github and we can build it. Thoughts?

maniphanh commented 7 years ago

I'm perfectly fine with that!