W3C validation - Githubissues

excelwebzone / EWZRecaptchaBundle

This bundle provides easy reCAPTCHA form field for Symfony.

MIT License

395 stars 160 forks source link

W3C validation #229

Closed lobodol closed 4 years ago

lobodol commented 5 years ago

Hello, I'm using this great bundle on my website but when I trigger the W3C Markup Validation, I've got 2 errors:

The frameborder attribute on the iframe element is obsolete. Use CSS instead.
The scrolling attribute on the iframe element is obsolete. Use CSS instead.

The "scrolling" & "frameborder" attributes are not supported in HTML5 so, my question is why keep them? Are they kept for kind of retrocompatibility?

Looking forward to reading you

JohJohan commented 4 years ago

Hi, i just started working with this bundle today but is this not added by Google Recaptcha itself? If i look for frameborder in this repository i cannot find any results

lobodol commented 4 years ago

When I started this issue I was using v1.5.11 of this bundle which included attributes frameborder in its templates: https://github.com/excelwebzone/EWZRecaptchaBundle/blob/v1.5.11/src/Resources/views/Form/ewz_recaptcha_widget.html.php

Since, I updated to version 1.5.21 where attributes frameborder have been removed.

Here is the commit where attributes were removed: https://github.com/excelwebzone/EWZRecaptchaBundle/commit/0fe11762e992cb4df3bb41a2ef52ae21dbf5be0a

I guess we can close this issue.