search

excelwebzone / EWZRecaptchaBundle

This bundle provides easy reCAPTCHA form field for Symfony.
MIT License
396 stars 160 forks source link

Unexpected "apply" tag (expecting closing tag for the "block" tag defined near line 2). #231

Open perk11 opened 5 years ago

perk11 commented 5 years ago

I am getting 

Unexpected "apply" tag (expecting closing tag for the "block" tag defined near line 2).

after installing the bundle with php composer.phar require excelwebzone/recaptcha-bundle having Twig 2.5.0/Symfony v3.4.15 Looks like https://github.com/excelwebzone/EWZRecaptchaBundle/commit/4dadc41576531d0f35b166b07007b5085210b237 was supposed to fix this, but it still happens

perk11 commented 5 years ago

Version 1.5.13 works fine, so it would be good to tag it as the last version that works with previous versions of twig, because right now 1.5.14 is marked as supporting older Twig versions, while that's not the case.

dxops commented 5 years ago

That is SemVer violation and a BC break. Would be great to get 1.16.0 instead of 1.5.14 and 1.5.15.

You will get 1.5.14 silently and will get errors. You will not receive 1.5.15 fix if your Twig version is 1.38.*(<1.40, <2.9), so that will not stop errors, the only one way is to downgrade the package to 1.5.13.

Would be nice to get 1.5.16 with https://github.com/excelwebzone/EWZRecaptchaBundle/commit/f526d3036616529a7c1be81e5ddea5af5b4fd331 reverted.

What a bummer!

chrisaligent commented 4 years ago

Thanks for posting this, was just wondering why our application was throwing errors after applying a minor security patch release for the framework we're using. Looks like it upgraded this Bundle to 1.5.14, which as @dxops noted shouldn't have been a breaking change: image

We're stuck on Twig 1.X (currently v1.38.4) until a major framework upgrade is applied, so I'll lock the Recaptcha Bundle to 1.5.13 until then to resolve the problem.