Closed Martin1982 closed 3 years ago
We have the same issue (PHP 8, Symfony 5.2.6). Everything works when the validation constraint is added directly to the form class.
Hello @excelwebzone ,
Why this issue is closed?
@ikvasnica gave a work around but it's not fixing the original issue.
Thanks
Hello @excelwebzone ,
Why this issue is closed?
@ikvasnica gave a work around but it's not fixing the original issue.
Thanks
The fix has been merged in https://github.com/excelwebzone/EWZRecaptchaBundle/commit/88646b56877007fd86e50438ddf1e29ee0905d32
thanks @Martin1982 for your fast answer.
We are using 1.5.26 as per our requirement (php 5.6).
Do you think you could also merge it into this version?
Thanks
@arirangz v1.5.29 should be backwards compatible according to semantic versioning conventions. So why not just run composer update
on your project to update to the latest?
Upgrading patch versions is almost always a good idea when Semver is respected;
Given a version number MAJOR.MINOR.PATCH, increment the:
MAJOR version when you make incompatible API changes, MINOR version when you add functionality in a backwards compatible manner, and PATCH version when you make backwards compatible bug fixes. Additional labels for pre-release and build metadata are available as extensions to the MAJOR.MINOR.PATCH format.
@arirangz v1.5.29 requires php ^7.1 Actually I installed the bundle yesterday and it installed v1.5.26
So do you think I can force to install v1.5.29?
Thanks
@arirangz That indeed looks like a BC break, since I only contributed for this patch this is possibly a new issue which needs to be reviewed by @excelwebzone
What I can suggest to help you forward is;
composer.json
When adding
The
cache:clear
command on Symfony 4.4 / PHP 7.4 gave an error;Adding the annotation to the class fixes this error