exceptionSPG / Bhagavad_Gita

I am building bhagavad gita app using bhagavad gita api here: https://docs.bhagavadgitaapi.in/
0 stars 0 forks source link

Warning from Bhagavad Gita API #1

Open PtPrashantTripathi opened 2 years ago

PtPrashantTripathi commented 2 years ago

https://github.com/gyawali-king49/Bhagavad_Gita/blob/8309aadfac535a8eda0143d242d3d14501456e56/lib/helper/chapter_data.dart#L10

Its not a best practice to expose api keys like this You should be aware of it right

I wanted you to remove this key from public repo

This is a warning cause your are clearly violating policy https://docs.bhagavadgitaapi.in/terms-and-conditions

@PtPrashantTripathi Owner of BHAGVADGITAAPI

exceptionSPG commented 2 years ago

I am sorry, that I didn’t notice. I will remove it, give a chance to once.

On Mon, 14 Feb 2022, 00:46 Pt. Prashant tripathi, @.***> wrote:

https://github.com/gyawali-king49/Bhagavad_Gita/blob/8309aadfac535a8eda0143d242d3d14501456e56/lib/helper/chapter_data.dart#L10

Its not a best practice to expose api keys like this You should be aware of it right

I wanted you to remove this key from public repo

This is a warning cause your are clearly violating policy https://docs.bhagavadgitaapi.in/terms-and-conditions

@PtPrashantTripathi https://github.com/PtPrashantTripathi Owner of BHAGVADGITAAPI

— Reply to this email directly, view it on GitHub https://github.com/gyawali-king49/Bhagavad_Gita/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOBNJHEIM4HML4B7GPBU5MTU275XJANCNFSM5OJQGSXQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

PtPrashantTripathi commented 2 years ago

Okay