executablebooks / sphinx-tomyst

A sphinx translator for producing myst syntax files
MIT License
5 stars 2 forks source link

[block_quote] fix nested math in blockquote context #84

Closed mmcky closed 4 years ago

mmcky commented 4 years ago

This PR fixes nested math in block_quotes

It can now parse block quotes such as

Let's listen to Wald longer:

    As a basis for choosing among critical regions the following
    considerations have been advanced by Neyman and Pearson: In accepting
    or rejecting :math:`H_0` we may commit errors of two kinds. We commit
    an error of the first kind if we reject :math:`H_0` when it is true;
    we commit an error of the second kind if we accept :math:`H_0` when
    :math:`H_1` is true. 

without adding > syntax to internal math components.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1f04d93). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #84   +/-   ##
=========================================
  Coverage          ?   60.23%           
=========================================
  Files             ?        1           
  Lines             ?      337           
  Branches          ?        0           
=========================================
  Hits              ?      203           
  Misses            ?      134           
  Partials          ?        0           
Flag Coverage Δ
#pytests 60.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f04d93...8d4d0f0. Read the comment docs.

github-actions[bot] commented 4 years ago

🚀 Deployed on https://5f7d60e26722c9a2aaea9e97--reverent-montalcini-de7189.netlify.app

mmcky commented 4 years ago

This isn't the perfect solution but it works. In the future should write a block_quote accumulator to support better nestedness

mmcky commented 4 years ago