exercism / awk

Exercism exercises in AWK.
https://exercism.org/tracks/awk
MIT License
18 stars 21 forks source link

Update test-all-your-base.bats #261

Closed Vincent-de-Comarmond closed 3 months ago

Vincent-de-Comarmond commented 3 months ago

0 should not be converted to the empty string when converting between bases. 0 should remain 0.

github-actions[bot] commented 3 months ago

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

glennj commented 3 months ago

@IsaacG do you remember why the output is empty when the input digits are all zeroes? This is from #63

glennj commented 3 months ago

@Vincent-de-Comarmond it's not enough to alter the tests: you have to make sure the example solution passes:

Vincent-de-Comarmond commented 3 months ago

@glennj - Updated example solution as asked

IsaacG commented 3 months ago

@IsaacG do you remember why the output is empty when the input digits are all zeroes? This is from #63

No. Probably an oversight. Though I would have expected the tests to be auto generated from the spec.

glennj commented 3 months ago

Thanks for working to fix this!