search

exercism / discussions

For discussing things like future features, roadmap, priorities, and other things that are not directly action-oriented (yet).
37 stars 5 forks source link

Enable WIP plugin to prevent WIP merges #217

Closed ErikSchierboom closed 6 years ago

ErikSchierboom commented 6 years ago

Sometimes, it makes sense to open a pull request that is still a work-in-progress. Such a PR should not be merged. Usually, the convention is to put WIP in the PR's title, which signifies to any reviewers that it should not be merged. However, you can still merge such a PR. There is a GitHub tool named wip that can be installed, which then disables merging of WIP PR's: https://github.com/apps/wip. Is this something we can add to our repo's?

iHiD commented 6 years ago

Yes yes yes...! This is the best idea ever.

ErikSchierboom commented 6 years ago

Yes yes yes...! This is the best idea ever.

😎

iHiD commented 6 years ago

This is so much better than my normal approach...

screenshot_20180621-132838

ErikSchierboom commented 6 years ago

Haha, that is brilliant! :D

emjayess commented 6 years ago

This was interesting to see come up, because I didn't know Github lacked this natively, nor did I know about it as a third-party option. I only know that the WIP: convention has been a native, first-class construct in Gitlab MR's and is a very well-supported piece of the merge workflow (and yes, hella useful).

kytrinyx commented 6 years ago

Done! I've installed this for all repositories on Exercism 👍

ErikSchierboom commented 6 years ago

I can confirm the plugin is installed correctly: https://github.com/exercism/csharp/pull/601

katrinleinweber commented 6 years ago

Just for the record: An alternative would be mergify.io: auto-merging after a pre-defined set of rules are met. Found it only yesterday :-/