exercism / go-test-runner

GNU Affero General Public License v3.0
15 stars 17 forks source link

Avoid that package level errors are ignored #69

Closed junedev closed 2 years ago

junedev commented 2 years ago

@norbs57 noticed that if you run the test on the website for the new pov exercise without changing the stub, the test is wrongly reported as passing. For reasons that are not really clear to me, the test failure in that exercise is not reported with the test name but just on package level. The test runner was ignoring all output lines that were not associated with a specific test case what lead to the wrong "passing" status.

This PR fixed the issue that pkg level output is ignored when there is no test level output.

Additionally, I will open another issue for changing the structure of the tests so that the output will be reported with the test case field. Nevertheless, I think it is good to fix the general test runner issue here in case it happens again for other exercises.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2011972974


Totals Coverage Status
Change from base Build 1962246066: 1.7%
Covered Lines: 355
Relevant Lines: 462

💛 - Coveralls