exercism / v2-configlet

Tool to assist in managing Exercism language tracks.
MIT License
16 stars 23 forks source link

[fetch-configlet] make more portable #177

Closed NobbZ closed 3 years ago

NobbZ commented 3 years ago

This makes the fetch-configlet script more portable by using /usr/bin/env bash as the interpreter for the file.

/usr/bin/env and its location are defined by POSIX, while /bin/bash is not, and different systems might have bash at different locations.

Aside of that, even nixOS which does not follow POSIX rules and conventions, does provide /usr/bin/env by default, while making bash available at /bin/bash or any other (for nixOS) non-default location would require messing around with the system in ways that are considered a flaw within the nixOS community as they introduce impurities.

NobbZ commented 3 years ago

After this change has merged, someone/something should PR all the tracks repositories to update their fetchers.

NobbZ commented 3 years ago

I will rebase once #178 got merged.

ErikSchierboom commented 3 years ago

178 has been merged!

ErikSchierboom commented 3 years ago

Thanks!