search

exercism / x86-64-assembly

Exercism exercises in x86-64 Assembly.
https://exercism.org/tracks/x86-64-assembly
MIT License
22 stars 18 forks source link

Add .note.GNU-stack section to every exercise #161

Closed 0x28 closed 2 years ago

0x28 commented 2 years ago

This PR solves issue #160.

bergjohan commented 2 years ago

Thank you for the PR, looks good!

@ErikSchierboom Could you help with merging this?

bergjohan commented 2 years ago

Noticed in another PR that this fails for macOS. I think we need to ifidn it for elf64 only:

%ifidn __OUTPUT_FORMAT__,elf64
section .note.GNU-stack noalloc noexec nowrite progbits
%endif
0x28 commented 2 years ago

@bergjohan done.

bergjohan commented 2 years ago

Perfect, thank you!

ErikSchierboom commented 2 years ago

Side note: @bergjohan turns out you don't have write permissions anymore. I seem to recall us having discussed this. Was this by your request, or did we forget to give you permissions?

bergjohan commented 2 years ago

@ErikSchierboom They were removed because I wasn't active as a maintainer. We discussed it a while back in another PR, and I decided to wait. But maybe it would be better if I got permissions again, so I don't have to ping you in every PR.

ErikSchierboom commented 2 years ago

Right. I think it would indeed be convenient to have you have write permissions. @ihid could you add @bergjohan to the x86-64-assembly team?

neenjaw commented 2 years ago

?, @ErikSchierboom, do you mean @bergjohan rather than me?

ErikSchierboom commented 2 years ago

I did. Fail!