search

exokitxr / exokit

Native VR/AR/XR engine for JavaScript 🦖
MIT License
997 stars 117 forks source link

Loading non-MR site should throw error #32

Open avaer opened 6 years ago

avaer commented 6 years ago

Currently loading e.g. http://youtube.com/ will lock up the browser, but it should instead display an error in MR.

TypeError: Cannot read property 'responseStart' of undefined
    at http://youtube.com/:1:1807
    at http://youtube.com/:1:2575
    at _runJavascript (C:\Users\avaer\Documents\GitHub\exokit\core.js:3215:15)
    at HTMLScriptElement.on.innerHTML (C:\Users\avaer\Documents\GitHub\exokit\core.js:2486:9)
    at HTMLScriptElement.emit (events.js:182:13)
    at HTMLScriptElement.EventEmitter.emit (domain.js:442:20)
    at HTMLScriptElement._emit (C:\Users\avaer\Documents\GitHub\exokit\core.js:1343:40)
    at HTMLScriptElement.set innerHTML [as innerHTML] (C:\Users\avaer\Documents\GitHub\exokit\core.js:2528:10)
    at HTMLScriptElement.run (C:\Users\avaer\Documents\GitHub\exokit\core.js:2549:24)
    at element.traverseAsync (C:\Users\avaer\Documents\GitHub\exokit\core.js:3186:16)
shawwn commented 6 years ago

If it locks up the browser, that’s probably a legit bug separate from this issue.

On May 4, 2018, at 3:06 AM, Avaer Kazmer notifications@github.com wrote:

Currently loading e.g. http://youtube.com/ will lock up the browser, but it should instead display an error in MR.

TypeError: Cannot read property 'responseStart' of undefined at http://youtube.com/:1:1807 at http://youtube.com/:1:2575 at _runJavascript (C:\Users\avaer\Documents\GitHub\exokit\core.js:3215:15) at HTMLScriptElement.on.innerHTML (C:\Users\avaer\Documents\GitHub\exokit\core.js:2486:9) at HTMLScriptElement.emit (events.js:182:13) at HTMLScriptElement.EventEmitter.emit (domain.js:442:20) at HTMLScriptElement._emit (C:\Users\avaer\Documents\GitHub\exokit\core.js:1343:40) at HTMLScriptElement.set innerHTML [as innerHTML] (C:\Users\avaer\Documents\GitHub\exokit\core.js:2528:10) at HTMLScriptElement.run (C:\Users\avaer\Documents\GitHub\exokit\core.js:2549:24) at element.traverseAsync (C:\Users\avaer\Documents\GitHub\exokit\core.js:3186:16) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/webmixedreality/exokit/issues/32, or mute the thread https://github.com/notifications/unsubscribe-auth/AADo8GHWV_IHGHdMtRvt8sRklS5HRumJks5tvAwSgaJpZM4TyQcM.