rmitsch
commented
1 year ago Hi @RXminuS, thanks for your contribution! This would be a useful feature. Before considering this for merging, we'd like this PR to also:
- implement a gzipped .jsonl
writer, as it'd make more sense to have both - update the
srslydocs w.r.t. the new functionality - add tests for the new functionality
Be aware that your current code is not valid Python. Let me know if you'd like to continue working on this! :-)
Add a simple modification to the jsonl reader that unzips a file. If the API instead of just allowing a path also allowed to pass in a file stream I could have handled it outside of this, but this seems the most straightforward solutions atm.