expo / videoplayer

Customizable controls for Expo video
83 stars 83 forks source link

videoPlayer don't resize on landscape mode #18

Open RedYggdrasil opened 6 years ago

RedYggdrasil commented 6 years ago

the video player don't seam to resize correctly with the parent view on landscape view for some reason. I tried different things, even putting the videoPlayer at the root of my application but the videoplayer don't fit the height of the screen, it goes below it.

example scenario at root : Texted on expo with a galaxy S8

<View style={{flex : 1}}>
        <VideoPlayer
          videoProps={{
            shouldPlay: true,
            resizeMode: Video.RESIZE_MODE_CONTAIN,
            source: {
              uri: defVid.link,
            },
          }}
          isPortrait={true}
          playFromPositionMillis={0}
          key={defVid.uvid}
        />
</View>

the result is a part of the video under the bottom of the screen on landscape mode, (but perhaps landscape is not the real deal here).

thomprycejones commented 6 years ago

Did you get this working?

RedYggdrasil commented 6 years ago

Played around, also I had to modify the VideoPlayer to manually set my ratio, but I eventually get something close enough to what I wanted, didn't remember all the little details of the process.

baselbj commented 6 years ago

@RedYggdrasil can you please provide us with your solution?