exponentcms / exponent-cms

Content Management, Simple.
exponentcms.org
GNU General Public License v2.0
60 stars 24 forks source link

Create jquery/bootstrap3 replacement controls for yui ones #1164

Open exponentcms opened 4 years ago

exponentcms commented 4 years ago

We'll need to create/write some new controls to replace our YUI ones...specifically:

The following controls have been deprecated in v2.2.3+ since they have NOT been used in 2.x

exponentcms commented 4 years ago

As a note this ticket applies to the /framework/core/forms/controls and not to any control or widget coded within a view.

exponentcms commented 4 years ago

Some additional notes:

exponentcms commented 4 years ago

Here are some recommended jquery replacements

Some non-form controls used

We already have a jquery slide show implementation and the countdown module uses a jquery control

exponentcms commented 4 years ago

(from [84e29d7a0fd14813451b9c3643e587cbd05c941a]) Adds new bootstrap (actually jquery) tag picker control [#1120] https://github.com/exponentcms/exponent-cms/commit/84e29d7a0fd14813451b9c3643e587cbd05c941a

exponentcms commented 4 years ago

(from [970dedf37ebd04bbf5e22e5fac8c017fb3e19ea6]) Replaces existing color control w/ jquery spectrum [#1120] https://github.com/exponentcms/exponent-cms/commit/970dedf37ebd04bbf5e22e5fac8c017fb3e19ea6

exponentcms commented 4 years ago

(from [3e815f7741f8dece35f401642f987ea03c520d87]) Replace yui2 lightbox used to optionally display calendar events w/ jquery colorbox [#1120 #747]] https://github.com/exponentcms/exponent-cms/commit/3e815f7741f8dece35f401642f987ea03c520d87

exponentcms commented 4 years ago

As a note:

exponentcms commented 4 years ago

(from [ca8431956d16e8d4b744d3ad484348e67b61f5a4]) New jquery calendar control (yuicalendarcontrol replacement) for bootstrap framework (initially), will become base for all calendar controls [#742 #1120] https://github.com/exponentcms/exponent-cms/commit/ca8431956d16e8d4b744d3ad484348e67b61f5a4

exponentcms commented 4 years ago

(from [d08cf31fed5d3e37728342353f3b9940efee1808]) Actual form control file for New jquery calendar control (yuicalendarcontrol replacement) for bootstrap framework (initially), will become base for all calendar controls [#742 #1120] https://github.com/exponentcms/exponent-cms/commit/d08cf31fed5d3e37728342353f3b9940efee1808

exponentcms commented 4 years ago

(from [cef8fe6cf62c518948524c60d637f9abb16ee719]) New jquery calendar control (calendarcontrol replacement) for bootstrap framework (initially), will become base for all calendar controls [#742 #1120] https://github.com/exponentcms/exponent-cms/commit/cef8fe6cf62c518948524c60d637f9abb16ee719

exponentcms commented 4 years ago

(from [5b3f885c60614d5d3ae5a1eb96ad78a45e97a9ff]) New jquery calendar control jquery datepicker plugin updated to v2.1.8 to fix an issue when instantiated within a 'tab' [#742 #1120] https://github.com/exponentcms/exponent-cms/commit/5b3f885c60614d5d3ae5a1eb96ad78a45e97a9ff

exponentcms commented 4 years ago

(from [e09c0784832894df38cf60aa97fbc5803e8966e5]) New jquery calendar control (yuicalendarcontrol replacement) for bootstrap framework (initially) [#742 #1120] https://github.com/exponentcms/exponent-cms/commit/e09c0784832894df38cf60aa97fbc5803e8966e5

exponentcms commented 4 years ago

(from [1215ebfaa5ead69500f1292a15a741268072b4a8]) Missing file for new yuidatetimecontrol, minor updates to elFinder [#1120 #742] https://github.com/exponentcms/exponent-cms/commit/1215ebfaa5ead69500f1292a15a741268072b4a8

exponentcms commented 4 years ago

(from [9d9f0d9542e443c1539a6fa6ad11a8cf4d1681dc]) Merge remote-tracking branch 'origin/develop' into newui

exponentcms commented 4 years ago

(from [9d9f0d9542e443c1539a6fa6ad11a8cf4d1681dc]) Merge remote-tracking branch 'origin/develop' into newui

exponentcms commented 4 years ago

(from [9d9f0d9542e443c1539a6fa6ad11a8cf4d1681dc]) Merge remote-tracking branch 'origin/develop' into newui

exponentcms commented 4 years ago

Some of the newer jquery/non-bootstrap controls were moved into 'jquery' so they can be enabled in a YUI theme by adding a 'framework'=>'jquery' which will then provide the newer controls. Some controls required an interface change, and replaced the older yui controls.

exponentcms commented 4 years ago

Can't forget that ddrerank widget and manage pages are yui-only at this point. Goal is to have a bootstrap3 site which uses NO YUI code/styles, etc...

Note: ddrerank & filemanagercontrol are similar in nature...sortable lists w/ optional thumbnail.

exponentcms commented 4 years ago

Additionally in our smarty plugins, the toggle smarty block plugin and prod_images (never used) & rating (only used in ecommerce store show view) smarty function plugins use YUI3...and lest we forget yimenu & yuimenubar smarty function plugins use YUI2 (however they build YUI2 menus)

And in our form controls, yuidatetimecontrol still uses some YUI code (all frameworks), and yuicalendarcontrol (jquery)

exponentcms commented 4 years ago

ddrerank widget updated/converted to jQuery/bootstrap3...locally have most of the filemanagercontrol converted also.

exponentcms commented 4 years ago

Locally I have the bootstrap3/jquery filemanagercontrol completed and finishing some testing, I also have a non-YUI ckeditorcontrol & tinymcecontrol working (won't work inside an old yui3 exp-tab).

exponentcms commented 4 years ago

filemanagercontrol updated to jquery

exponentcms commented 4 years ago

Ok, a prioritized list

Highest priority - non-ecommerce used in a bootstrap3 theme

Second priority - ecommerce used in a bootstrap3 theme

No priority - not in the above groups

exponentcms commented 4 years ago

Because these lists are so long, here are some repetitive things (non-prioritied) that the solution will provide multiple fixes at once.

exponentcms commented 4 years ago

deprecated files listed above removed

exponentcms commented 4 years ago

The nav manage hierarchy view has been updated to jquery/bootstrap3.

Also, the new listbuildercontrol and tagpickercontrol use jqueryui and should be updated to use jquery/bootstrap3 instead.

exponentcms commented 4 years ago

(from [c5aaff64507feff370628fa8115f02d025ecdde0]) Updates bs3 listbuildercontrol to use bs3 and not jqueryui [#1120] https://github.com/exponentcms/exponent-cms/commit/c5aaff64507feff370628fa8115f02d025ecdde0

exponentcms commented 4 years ago

(from [8e0eefb1de77b082abc98a4d375de2a84ca1d104]) Updates bs2/bs3 tagpickerercontrol to not use jqueryui; fixes passing of empty tags to the tag picker; also fixes possible unecessary multiple loading of tag-it script adds bootstrap-tagsinput & typeahead plugins [#1120] https://github.com/exponentcms/exponent-cms/commit/8e0eefb1de77b082abc98a4d375de2a84ca1d104

exponentcms commented 4 years ago

(from [84b88813c8fc7da81a2ea11cb9a9abe173b598d0]) Updates bs3 yuicalendarcontrol & yuidatetimecontrol to not use yui[#1120] https://github.com/exponentcms/exponent-cms/commit/84b88813c8fc7da81a2ea11cb9a9abe173b598d0

exponentcms commented 4 years ago

(from [1bb4cd314228e98ece142c57c4c854c0c2771527]) Removes commented code from recent bs3 control updates [#1120] https://github.com/exponentcms/exponent-cms/commit/1bb4cd314228e98ece142c57c4c854c0c2771527

exponentcms commented 4 years ago

(from [ab10bb2b19132443e9e4152a11eab92660aaa421]) Regression fix to ensure yui-min.js is loaded on views with YUI code since we can't assume that YUI is always loaded now (ecommerce in bs3 theme) [#1120] https://github.com/exponentcms/exponent-cms/commit/ab10bb2b19132443e9e4152a11eab92660aaa421

exponentcms commented 4 years ago

(from [86b79adb425a007ea4260c2fccb0b513c9dea5e5]) Fixes a number of anomalies (& inefficient code) in form controls due to an assumption that if a param was set, it was set to 1 [#1120] https://github.com/exponentcms/exponent-cms/commit/86b79adb425a007ea4260c2fccb0b513c9dea5e5

exponentcms commented 4 years ago

(from [569b9ce29d234ec55d3133d29a017e1f9e22fcee]) Adds a non-yui, but jquery only popupdatetimecontrol [#1120] https://github.com/exponentcms/exponent-cms/commit/569b9ce29d234ec55d3133d29a017e1f9e22fcee

exponentcms commented 4 years ago

(from [b390bb36cf73217b60c005ce6b029e4dbae266d1]) Updates bs3 listbuildercontrol to use bs3 and not jqueryui [#1120] (cherry picked from commit c5aaff6) https://github.com/exponentcms/exponent-cms/commit/b390bb36cf73217b60c005ce6b029e4dbae266d1

exponentcms commented 4 years ago

(from [9dd26cb4b96c0dfeb00fd6bbc905c3c375735aca]) Updates bs2/bs3 tagpickerercontrol to not use jqueryui; fixes passing of empty tags to the tag picker; also fixes possible unecessary multiple loading of tag-it script adds bootstrap-tagsinput & typeahead plugins [#1120] (cherry picked from commit 8e0eefb) https://github.com/exponentcms/exponent-cms/commit/9dd26cb4b96c0dfeb00fd6bbc905c3c375735aca

exponentcms commented 4 years ago

(from [9810c10bc1f67652976cac12643618d67c749e79]) Updates bs3 yuicalendarcontrol & yuidatetimecontrol to not use yui[#1120] (cherry picked from commit 84b8881) https://github.com/exponentcms/exponent-cms/commit/9810c10bc1f67652976cac12643618d67c749e79

exponentcms commented 4 years ago

(from [3ce69d754790e82c4174a50cf6fe90475f15f1a9]) Removes commented code from recent bs3 control updates [#1120] (cherry picked from commit 1bb4cd3) https://github.com/exponentcms/exponent-cms/commit/3ce69d754790e82c4174a50cf6fe90475f15f1a9

exponentcms commented 4 years ago

(from [e521e80f95a3173884619b5770600a487efcb3d5]) Regression fix to ensure yui-min.js is loaded on views with YUI code since we can't assume that YUI is always loaded now (ecommerce in bs3 theme) [#1120] (cherry picked from commit ab10bb2) https://github.com/exponentcms/exponent-cms/commit/e521e80f95a3173884619b5770600a487efcb3d5

exponentcms commented 4 years ago

(from [8c6fd0df42e280f8f4d2b8704bd4e80439fe41a2]) Fixes a number of anomalies (& inefficient code) in form controls due to an assumption that if a param was set, it was set to 1 [#1120] (cherry picked from commit 86b79ad) https://github.com/exponentcms/exponent-cms/commit/8c6fd0df42e280f8f4d2b8704bd4e80439fe41a2

exponentcms commented 4 years ago

(from [80692f4db13c5f301146bd714351aec7a53c6633]) Adds a non-yui, but jquery only popupdatetimecontrol [#1120] (cherry picked from commit 569b9ce) https://github.com/exponentcms/exponent-cms/commit/80692f4db13c5f301146bd714351aec7a53c6633

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

Lighthouse URL: https://exponentcms.lighthouseapp.com/projects/61783/tickets/1120