(Fix) InSpec resources: postgres_cluster, postgres_extension & postgres_user were refactored.
(Fix) Test Kitchen: use one test recipe instead of one-recipe-per-pg-version.
(Fix) Test Kitchen: use only official images.
(Fix) Test Kitchen: tests for Chef 11 support were removed, as outdated.
(Fix) Test Kitchen: Test for Postgresql 9.0 were removed; there is PostgreSQL 9.0 package on modern systems.
(Fix) [postgresql] fix ruby_block notifications.
(Fix) [pgtest] user creation should be invoked using encrypted_password attribute for better compatibility.
Few more comments:
I think that the support of Debian 7, PostgreSQL 9.0 & Chef 11 brings us more trouble than benefit. Chef 11 is absolutely outdated and Debian 7 long-term support ends in may 2018, so I've made a decision to drop them and removed them from Test Kitchen configurations.
I've completely removed ServerSpec tests in favor of InSpec ones which were already there. Had to refactor them thought. I think that an implicit version & cluster name determination is a "malicious" practice.
I was also able to remove a lot of duplicated test recipes.
I've run local tests on VirtualBox as well as local tests on Docker. Test Kitchen configurations for both should work fine. I was unable to check & fix your cloud-based Test Kitchen configuration, sorry.
Please, review my PR. I would be really glad if you can provide any kind of comments or thoughts about it and, possibly, merge it.
postgres_cluster
,postgres_extension
&postgres_user
were refactored.encrypted_password
attribute for better compatibility.Few more comments:
Please, review my PR. I would be really glad if you can provide any kind of comments or thoughts about it and, possibly, merge it.
Thank you!