eylles
commented
2 weeks ago Thanks, i will be honest, i did find the saturation issue but was planing on working it later, also it is not a suprise that there were issues with the pr, this is not a jab at the author but rather that any new adittion of features is bound to have at least one issue from the very nature of software.
As for it working as intended or not that is something i'm used to check in preparation for a release rather than after every merge.
All that to say it looks good to me but i may or may not make changes for the next release if i find another issue.
Love the idea in https://github.com/eylles/pywal16/pull/62, but the merged version didn't seem to do anything upon testing, so worked through the bugs we found. This is our first contribution to this repo, so if we've done anything wrong or in bad style, we'd appreciate the feedback.
Also bumped the cache version since the new cache matching format is expressly incompatible with the old one.
As a side note, the colours generated by increased contrast ratio bug us quite a bit, since increased luminance (and decreased saturation) tend to make what would be distinct colours look nearly the same. It might be wiser to, if a majority of colours come up short in desired_luminance, to darken the background and lighten the foreground instead of acting on each colour separately.